Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.4_HLT_X] HLT configurations for 2022 MC: remove menu 2022 V1.2 #46034

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[12.4_HLT_X] HLT configurations for 2022 MC: remove menu 2022 V1.2 #46034

merged 2 commits into from
Oct 3, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 18, 2024 •
edited
Loading

PR description:

Development of HLT menu for CMSSW_12_4_HLT_X.
This update is meant exclusively for the Summer2024 production of Run 3 MC.

This PR is NOT a backport.

This PR is a follow-up to #45939.
The goal of this PR is to remove the frozen menu 2022 V1.2 only from CMSSW_12_4_HLT_X (which is the branch in which CMS targets to run the HLT step of the Run3Summer2024 MC production).
As it was agreed to use the frozen menu V1.5 for that (that was proposed in #45939), the earlier version V1.2 (for 2022 pre-EE era) will not be needed in this particular branch, thus it is removed to avoid possible confusions.
In order to remove the menu from the release and avoid massive relval failures, jointly with the removal commit 72a3bd0 there is an update of the GlobalTags in autoCond.py (commit adc04b6) for the following keys:

  • run3_hlt_relval : 124X_dataRun3_HLT_relval_v9 → 124X_dataRun3_HLT_relval_v10 (diff)
  • run3_data_relval : 124X_dataRun3_relval_v13 → 124X_dataRun3_relval_v14 (diff)
  • phase1_2022_realistic : 124X_mcRun3_2022_realistic_v12 → 124X_mcRun3_2022_realistic_v13 (diff)
  • phase1_2023_realistic : 124X_mcRun3_2023_realistic_v13 → 124X_mcRun3_2023_realistic_v14 (diff)
  • phase1_2024_realistic : 124X_mcRun3_2024_realistic_v13 → 124X_mcRun3_2024_realistic_v14 (diff)
  • phase1_2022_realistic_postEE : 124X_mcRun3_2022_realistic_postEE_v1 → 124X_mcRun3_2022_realistic_postEE_v3 (diff)

The first five of them contain the L1T menu tag L1Menu_Collisions2022_v1_2_0_xml (which is incompatible with the menu 2022 V1.5 that we are targeting to use for tests), while the last is an update requested by AlCa.
The exact content of the MC GT is still being discussed in this cmsTalk thread, but these are intermediate GlobalTags for these keys that contain instead L1Menu_Collisions2022_v1_3_0-d1_xml (compatible with menu V1.5) such that we could (at least techincally) remove V1.2 from this branch.

PR validation:

I performed the following tests:

  • addOnTests.py runs fine.
  • runTheMatrix.py -l limited --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be backported.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for CMSSW_12_4_HLT_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @consuegs, @mmusich, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @mmusich, @rsreds, @silviodonato, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 18, 2024

I am opening this PR in "Draft mode" because the update of autoCond.py is not complete, the 2023 relvals have the same issue:

Incidentally, I checked with this script which are the GTs in autoCond that still contain the L1T menu L1Menu_Collisions2022_v1_2_0_xml and here they are:

key: run3_data_relval : GlobalTag: 124X_dataRun3_relval_v13 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase1_2022_design : GlobalTag: 124X_mcRun3_2022_design_v7 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase1_2022_cosmics : GlobalTag: 124X_mcRun3_2022cosmics_realistic_deco_v13 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase1_2022_cosmics_design : GlobalTag: 124X_mcRun3_2022cosmics_design_deco_v7 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase1_2022_realistic_hi : GlobalTag: 124X_mcRun3_2022_realistic_HI_v12 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase1_2023_realistic : GlobalTag: 124X_mcRun3_2023_realistic_v13 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase1_2024_realistic : GlobalTag: 124X_mcRun3_2024_realistic_v13 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: phase2_realistic : GlobalTag: 124X_mcRun4_realistic_v8 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: upgrade2021 : GlobalTag: 124X_mcRun3_2022_design_v7 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: upgrade2022 : GlobalTag: 124X_mcRun3_2022_design_v7 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml
key: upgradePLS3 : GlobalTag: 124X_mcRun4_realistic_v8 | Record: L1TUtmTriggerMenuRcd, Label: -, Tag: L1Menu_Collisions2022_v1_2_0_xml

I would still at least update the keys run3_data_relval , phase1_2023_realistic and phase1_2024_realistic.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

I am opening this PR in "Draft mode" because the update of autoCond.py is not complete, the 2023 relvals have the same issue:

@cms-sw/alca-l2 do you have any news about this?

@atpathak
Copy link

Dear @mmusich,

Please update of the GlobalTags in autoCond.py :

phase1_2023_realistic : 124X_mcRun3_2023_realistic_v13 ->124X_mcRun3_2023_realistic_v14 (diff)
The v14 is now updated with L1Menu_Collisions2022_v1_3_0-d1_xml

phase1_2024_realistic : 124X_mcRun3_2024_realistic_v13 ->124X_mcRun3_2024_realistic_v14 (diff)
The v14 is now updated with L1Menu_Collisions2022_v1_3_0-d1_xml

run3_data_relval : 124X_dataRun3_relval_v13 ->124X_dataRun3_relval_v14 (diff)
The v14 is now updated with L1Menu_Collisions2022_v1_3_0-d1_xml

Please let me know if you need anywhere else to update in order to test this PR. Thanks

@cmsbuild
Copy link
Contributor

Pull request #46034 was updated. @Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @mmusich, @perrotta can you please check and sign again.

@perrotta @atpathak @mmusich
Update L1T meu tag in autoCond GTs to L1Menu_Collisions2022_v1_3_0-d1…
adc04b6 
…_xml, as needed by the HLT menus HLT:2022v14 (or v15)

Co-authored-by: atpathak <pathakatanu01@gmail.com>
@cmsbuild
Copy link
Contributor

Pull request #46034 was updated. @Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @mmusich, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92b987/41786/summary.html
COMMIT: adc04b6
CMSSW: CMSSW_12_4_HLT_X_2024-09-22-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46034/41786/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 107 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 18957 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3717370
  • DQMHistoTests: Total failures: 67276
  • DQMHistoTests: Total nulls: 73
  • DQMHistoTests: Total successes: 3649999
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -20413.034999999996 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -308.312 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -1459.617 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -726.266 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -279.291 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -210.264 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): -163.386 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -122.679 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 120.312 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0,... ): -34.929 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -30.352 KiB HLT/HLTJETMET
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 8 / 50 workflows

@mmusich mmusich marked this pull request as ready for review September 28, 2024 01:50
@mmusich
Copy link
Contributor Author

mmusich commented Sep 28, 2024

+hlt

@perrotta
Copy link
Contributor

+alca

  • For AlCa mostly L1T menus updated in the GT to be compatible with the HLT menus 2022 V1.4 and 2022 V1.5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_HLT_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e698af8 into cms-sw:CMSSW_12_4_HLT_X Oct 3, 2024
9 checks passed
@mmusich mmusich deleted the HLTDevelopment124X branch October 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmusich @cmsbuild @atpathak @perrotta @antoniovilela