-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2024 HI eras to reco processing configuation #45981
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
Configuration/DataProcessing/python/Impl/ppEra_Run3_2024_UPC.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#!/usr/bin/env python3 | ||
""" | ||
_ppEra_Run3_2024_UPC_ | ||
Scenario supporting UPC collisions for 2024 | ||
""" | ||
|
||
import os | ||
import sys | ||
|
||
from Configuration.DataProcessing.Reco import Reco | ||
import FWCore.ParameterSet.Config as cms | ||
from Configuration.Eras.Era_Run3_2024_UPC_cff import Run3_2024_UPC | ||
|
||
from Configuration.DataProcessing.Impl.pp import pp | ||
|
||
class ppEra_Run3_2024_UPC(pp): | ||
def __init__(self): | ||
pp.__init__(self) | ||
self.recoSeq='' | ||
self.cbSc='pp' | ||
self.eras=Run3_2024_UPC | ||
self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024_UPC' ] | ||
self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024_UPC' ] | ||
self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024_UPC' ] | ||
""" | ||
_ppEra_Run3_2024_UPC_ | ||
Implement configuration building for data processing for proton | ||
collision data taking for Run3_2024 | ||
""" |
29 changes: 29 additions & 0 deletions
29
Configuration/DataProcessing/python/Impl/ppEra_Run3_2024_ppRef.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#!/usr/bin/env python3 | ||
""" | ||
_ppEra_Run3_2024_ppRef_ | ||
Scenario supporting ppRef collisions for 2024 | ||
""" | ||
|
||
import os | ||
import sys | ||
|
||
from Configuration.DataProcessing.Reco import Reco | ||
import FWCore.ParameterSet.Config as cms | ||
from Configuration.Eras.Era_Run3_2024_ppRef_cff import Run3_2024_ppRef | ||
|
||
from Configuration.DataProcessing.Impl.pp import pp | ||
|
||
class ppEra_Run3_2024_ppRef(pp): | ||
def __init__(self): | ||
pp.__init__(self) | ||
self.recoSeq='' | ||
self.cbSc='pp' | ||
self.eras=Run3_2024_ppRef | ||
self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024_ppRef' ] | ||
self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024_ppRef' ] | ||
self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024_ppRef' ] | ||
""" | ||
_ppEra_Run3_2024_ppRef_ | ||
Implement configuration building for data processing for proton | ||
collision data taking for Run3_2024 | ||
""" |
34 changes: 34 additions & 0 deletions
34
Configuration/DataProcessing/python/Impl/ppEra_Run3_pp_on_PbPb_2024.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#!/usr/bin/env python3 | ||
""" | ||
_ppEra_Run3_pp_on_PbPb_2024_ | ||
|
||
Scenario supporting heavy ions collisions | ||
|
||
""" | ||
|
||
import os | ||
import sys | ||
|
||
from Configuration.DataProcessing.Reco import Reco | ||
import FWCore.ParameterSet.Config as cms | ||
from Configuration.Eras.Era_Run3_pp_on_PbPb_2024_cff import Run3_pp_on_PbPb_2024 | ||
|
||
from Configuration.DataProcessing.Impl.pp import pp | ||
|
||
class ppEra_Run3_pp_on_PbPb_2024(pp): | ||
def __init__(self): | ||
pp.__init__(self) | ||
self.recoSeq='' | ||
self.cbSc='pp' | ||
self.isRepacked=True | ||
self.eras=Run3_pp_on_PbPb_2024 | ||
self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_pp_on_PbPb_2024' ] | ||
self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_pp_on_PbPb_2024' ] | ||
self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_pp_on_PbPb_2024' ] | ||
""" | ||
_ppEra_Run3_pp_on_PbPb_2024_ | ||
|
||
Implement configuration building for data processing for pp-like processing of HI | ||
collision data taking for Run3 | ||
|
||
""" |
35 changes: 35 additions & 0 deletions
35
Configuration/DataProcessing/python/Impl/ppEra_Run3_pp_on_PbPb_approxSiStripClusters_2024.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#!/usr/bin/env python3 | ||
""" | ||
_ppEra_Run3_pp_on_PbPb_approxSiStripClusters_2024_ | ||
|
||
Scenario supporting heavy ions collisions | ||
|
||
""" | ||
|
||
import os | ||
import sys | ||
|
||
from Configuration.DataProcessing.Reco import Reco | ||
from Configuration.Eras.Era_Run3_pp_on_PbPb_approxSiStripClusters_2024_cff import Run3_pp_on_PbPb_approxSiStripClusters_2024 | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.DataProcessing.Impl.pp import pp | ||
|
||
class ppEra_Run3_pp_on_PbPb_approxSiStripClusters_2024(pp): | ||
def __init__(self): | ||
pp.__init__(self) | ||
self.recoSeq='' | ||
self.cbSc='pp' | ||
self.isRepacked=True | ||
self.eras=Run3_pp_on_PbPb_approxSiStripClusters_2024 | ||
self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_pp_on_PbPb_approxSiStripClusters_2024' ] | ||
self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_pp_on_PbPb_approxSiStripClusters_2024' ] | ||
self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_pp_on_PbPb_approxSiStripClusters_2024' ] | ||
|
||
""" | ||
_ppEra_Run3_pp_on_PbPb_approxSiStripClusters_2024_ | ||
|
||
Implement configuration building for data processing for pp-like processing of HI | ||
collision data taking for Run3 with approxSiStripClusters (rawprime format) | ||
|
||
""" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mandrenguyen, IIUC the datasets that now you would be processing with this scenario are the ones that last year were processed with
hiForwardScenario = "ppEra_Run3_2023_repacked"
.That scenario has
cmssw/Configuration/DataProcessing/python/Impl/ppEra_Run3_2023_repacked.py
Line 23 in 2647f99
why is it not implemented here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes, thanks for spotting it.
I guess that's in relation to this failure right? :
#46186 (comment)
Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix is here: #46194