Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VISUALIZATION] Changes suggested by new llvm18 clang-format #45898

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Fireworks/Calo/interface/scaleMarker.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class FWViewContext;
namespace fireworks {
struct scaleMarker {
scaleMarker(TEveScalableStraightLineSet* ls, float et, float e, const FWViewContext* vc)
: m_ls(ls), m_et(et), m_energy(e), m_vc(vc){};
: m_ls(ls), m_et(et), m_energy(e), m_vc(vc) {}

virtual ~scaleMarker() {}

Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Calo/plugins/FWTracksterHitsProxyBuilder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ void FWTracksterHitsProxyBuilder::build(const ticl::Trackster &iData,
}
}
} // End of loop over rechits of a single layercluster
} // End loop over the layerclusters of the trackster
} // End loop over the layerclusters of the trackster

hex_boxset->RefitPlex();
boxset->RefitPlex();
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/interface/FWJobMetadataUpdateRequest.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

class FWJobMetadataUpdateRequest {
public:
virtual ~FWJobMetadataUpdateRequest(){};
virtual ~FWJobMetadataUpdateRequest() {}
};

#endif
2 changes: 1 addition & 1 deletion Fireworks/Core/interface/FWProxyBuilderBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class FWProxyBuilderBase {

virtual void modelChanges(const FWModelIds&, Product*);

virtual void scaleProduct(TEveElementList* parent, FWViewType::EType, const FWViewContext* vc){};
virtual void scaleProduct(TEveElementList* parent, FWViewType::EType, const FWViewContext* vc) {}

FWProxyBuilderBase(const FWProxyBuilderBase&); // stop default
const FWProxyBuilderBase& operator=(const FWProxyBuilderBase&); // stop default
Expand Down
4 changes: 2 additions & 2 deletions Fireworks/Core/interface/FWViewManagerBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ class FWViewManagerBase {
void modelChangesComingSlot();
void modelChangesDoneSlot();
void colorsChangedSlot();
virtual void eventBegin(){};
virtual void eventEnd(){};
virtual void eventBegin() {}
virtual void eventEnd() {}

// ---------- const member functions ---------------------

Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/src/CSGConnector.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class CSGActionSupervisor;

class CSGConnector : public TQObject {
public:
CSGConnector(CSGAction *action, CSGActionSupervisor *supervisor) : m_action(action), m_supervisor(supervisor){};
CSGConnector(CSGAction *action, CSGActionSupervisor *supervisor) : m_action(action), m_supervisor(supervisor) {}
//virtual ~CSGConnector();

// ---------- member functions ---------------------------
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/src/FW3DViewDistanceMeasureTool.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class FW3DViewDistanceMeasureTool {
enum EPickAction { kPnt1, kPnt2, kNone };

FW3DViewDistanceMeasureTool();
virtual ~FW3DViewDistanceMeasureTool(){};
virtual ~FW3DViewDistanceMeasureTool() {}

void resetAction();

Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/src/FWGeometryTableViewBase.cc
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ namespace {
kStructureNotifyMask | kFocusChangeMask | kEnterWindowMask | kLeaveWindowMask);
}

~FWGeometryVF() override{};
~FWGeometryVF() override {}

Bool_t HandleKey(Event_t* event) override {
if (event->fCode == (UInt_t)gVirtualX->KeysymToKeycode(kKey_Escape)) {
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Core/src/fwPaletteExtra.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace fireworks {
bool whiteBg;
FWColorManager::EPalette id;
PaletteExtraTopBottomIndices(float (*iColors)[3], bool iIsWhiteBg, FWColorManager::EPalette iId)
: colVals(iColors), whiteBg(iIsWhiteBg), id(iId){};
: colVals(iColors), whiteBg(iIsWhiteBg), id(iId) {}

void set(int i, Color_t cidx) {
if (whiteBg) {
Expand Down
4 changes: 2 additions & 2 deletions Fireworks/FWInterface/src/FWPSetCellEditor.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@

class FWPSetCellEditor : public TGTextEntry {
public:
FWPSetCellEditor(const TGWindow* w, const char* txt) : TGTextEntry(w, txt){};
~FWPSetCellEditor() override{};
FWPSetCellEditor(const TGWindow* w, const char* txt) : TGTextEntry(w, txt) {}
~FWPSetCellEditor() override {}
bool HandleKey(Event_t* event) override;
bool apply(FWPSetTableManager::PSetData& data, FWPSetTableManager::PSetData& parent);
};
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Tracks/plugins/FWItemTrackAccessors.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
class BeamSpotSingleAccessor : public FWItemSingleAccessor {
public:
BeamSpotSingleAccessor(const TClass* x) : FWItemSingleAccessor(x) {}
~BeamSpotSingleAccessor() override{};
~BeamSpotSingleAccessor() override {}
REGISTER_FWITEMACCESSOR_METHODS();
};

Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Tracks/plugins/FWSiPixelDigiProxyBuilder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ void FWSiPixelDigiProxyBuilder::build(const FWEventItem* iItem, TEveElementList*
pointSet->SetNextPoint(globalPoint[0], globalPoint[1], globalPoint[2]);
}
} // end of iteration over digis in range
} // end of iteration over the DetSetVector
} // end of iteration over the DetSetVector
}

REGISTER_FWPROXYBUILDER(FWSiPixelDigiProxyBuilder,
Expand Down
2 changes: 1 addition & 1 deletion Fireworks/Tracks/plugins/FWSiStripDigiProxyBuilder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void FWSiStripDigiProxyBuilder::build(const FWEventItem* iItem, TEveElementList*

lineSet->AddLine(globalTop[0], globalTop[1], globalTop[2], globalBottom[0], globalBottom[1], globalBottom[2]);
} // end of iteration over digis
} // end of iteration over the DetSetVector
} // end of iteration over the DetSetVector
}

REGISTER_FWPROXYBUILDER(FWSiStripDigiProxyBuilder,
Expand Down