Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Fix issue with ZdcSimpleRecAlgo_Run3.cc #45869

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

matt2275
Copy link
Contributor

@matt2275 matt2275 commented Sep 3, 2024

PR description:

Fixed issue where digi size was determined by QIE8 method instead of QIE10 method. Issue was raised here

PR validation:

Did the following runthematrix :

runTheMatrix.py -l 142 -e --ibeos

This job previously failed before the fix was implemented

Fixed issue where digi size was determined using QIE8 method instead of QIE10
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

A new Pull Request was created by @matt2275 for CMSSW_14_1_X.

It involves the following packages:

  • RecoLocalCalo/HcalRecAlgos (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d20aa/41272/summary.html
COMMIT: c66691b
CMSSW: CMSSW_14_1_X_2024-09-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45869/41272/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328391
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328368
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 4, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen mandrenguyen changed the title Backport fix issue with ZdcSimpleRecAlgo_Run3.cc [14_1_X] [14_1_X] Fix issue with ZdcSimpleRecAlgo_Run3.cc Sep 6, 2024
@mandrenguyen
Copy link
Contributor

backport of #45868

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 99c1983 into cms-sw:CMSSW_14_1_X Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants