Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename modifier run3_2024_L1T to stage2L1Trigger_2024 [14_1_X] #45862

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Sep 3, 2024

backport of #45713

PR description:

From the description of #45713.

This PR suggests to rename the modifier introduced in #45352, in order to use a name that's consistent with other existing modifiers specific to the Stage-2 L1 Trigger, see
https://github.com/cms-sw/cmssw/blob/7320a6bb38b604b8c69c7e1ee57539fe71a53b9e/Configuration/Eras/python/Modifier_stage2L1Trigger_2017_cff.py
https://github.com/cms-sw/cmssw/blob/7320a6bb38b604b8c69c7e1ee57539fe71a53b9e/Configuration/Eras/python/Modifier_stage2L1Trigger_2018_cff.py
https://github.com/cms-sw/cmssw/blob/7320a6bb38b604b8c69c7e1ee57539fe71a53b9e/Configuration/Eras/python/Modifier_stage2L1Trigger_2021_cff.py

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#45713

Renaming of a modifier, to be done for consistency in all affected cycles, i.e. 14_0_X and above (see #45713 (comment)).

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

A new Pull Request was created by @missirol for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • DQM/L1TMonitor (dqm)
  • L1Trigger/L1TMuonBarrel (l1)

@aloeliger, @antoniovagnerini, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @nothingface0, @rappoccio, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@AnnikaStein, @Martin-Grunewald, @dinyar, @eyigitba, @fabiocos, @makortel, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Sep 3, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4cb97/41235/summary.html
COMMIT: f1c65a0
CMSSW: CMSSW_14_1_X_2024-09-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45862/41235/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328391
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328366
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 46d01a6 into cms-sw:CMSSW_14_1_X Sep 10, 2024
9 checks passed
@missirol missirol deleted the devel_renameL1T2024Mod_141X branch September 11, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants