Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Add option to sort candidates by pT in Unified Particle Transformer and PR 45689 #45847

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

Backport of: #45843 and #45689

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for CMSSW_14_0_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @hqucms, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2024

please test

@stahlleiton
Copy link
Contributor Author

please test

why is the test still pending?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-857219/41234/summary.html
COMMIT: f9bbcef
CMSSW: CMSSW_14_0_X_2024-09-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45847/41234/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 3, 2024

Test failure is unrelated

@mandrenguyen
Copy link
Contributor

ignore tests-rejected with ib-failure

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b9bd09 into cms-sw:CMSSW_14_0_X Sep 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants