Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RecoTracker/PixelVertexFinding to RecoVertex/PixelVertexFinding #45842

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 30, 2024

PR description:

Title says it all, as promised at #41223 (comment).
Purely technical, no regressions expected

PR validation:

Tested:

  • unit tests: scram b runtests
  • addOnTests.py
  • runTheMatrix.py -l limited --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CalibTracker/Configuration (alca)
  • Configuration/EventContent (operations)
  • Configuration/StandardSequences (operations)
  • DQM/Integration (dqm)
  • DQM/SiPixelMonitorTrack (dqm)
  • DQM/SiStripMonitorClient (dqm)
  • RecoTracker/Configuration (reconstruction)
  • RecoTracker/PixelVertexFinding (reconstruction)
  • RecoVertex/Configuration (reconstruction)
  • RecoVertex/PixelVertexFinding (****)
  • Validation/TrackerRecHits (dqm)

The following packages do not have a category, yet:

RecoVertex/PixelVertexFinding
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@antoniovagnerini, @antoniovilela, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @jfernan2, @mandrenguyen, @nothingface0, @perrotta, @rappoccio, @rvenditti, @saumyaphor4252, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @arossi83, @batinkov, @dgulhan, @echabert, @fabiocos, @felicepantaleo, @fioriNTU, @francescobrivio, @gbenelli, @gpetruc, @idebruyn, @jandrea, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @robervalwalsh, @rovere, @rsreds, @sameasy, @slomeo, @sroychow, @threus, @tocheng, @venturia, @wmtford, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich force-pushed the move_PixelVertexFinding_from_RecoTracker_to_RecoVertex_14_2_X branch from a3b44fe to 243a040 Compare August 31, 2024 08:19
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45842/41590

  • Found files with invalid states:
    • RecoVertex/PixelVertexFinding/python/PixelVertexes_cff.py:
    • RecoVertex/PixelVertexFinding/python/PixelVertexes_cfi.py:

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Aug 31, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 104KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-213668/41205/summary.html
COMMIT: 243a040
CMSSW: CMSSW_14_2_X_2024-08-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45842/41205/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@mmusich
Copy link
Contributor Author

mmusich commented Sep 2, 2024

@cmsbuild ping

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2024

+1

@mmusich
Copy link
Contributor Author

mmusich commented Sep 3, 2024

@cms-sw/dqm-l2 kind ping

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

  • P5 tests OK.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 5, 2024

@cms-sw/orp-l2 can you merge this PR? Soon there will be many conflicts to other PRs changing same code.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 738cce2 into cms-sw:master Sep 6, 2024
11 checks passed
@mmusich mmusich deleted the move_PixelVertexFinding_from_RecoTracker_to_RecoVertex_14_2_X branch September 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants