-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve QTest Pixel DQM (BP to [14_0_X]) #45841
Improve QTest Pixel DQM (BP to [14_0_X]) #45841
Conversation
A new Pull Request was created by @alaperto for CMSSW_14_0_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
please test |
backport of #45840 |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
ping @cms-sw/dqm-l2 |
Hi @tjavaid is there a reason why you're using Online Playback machine?
|
Hi @alaperto , yes. That's also my perception that it also propagates to the Online Summary maps as I looked at the existing plots (thanks for checking from your side as well). |
Hi @tjavaid looks great! Please, proceed. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Changes to Pixel DQM Quality Test
L1 cluster size:
Issue: HI runs from 2023 and early 2024 pp runs had cluster size > 6 (outside allowed range)
GUI plot: https://tinyurl.com/2ccppw6k
GUI summary: https://tinyurl.com/2dysgbhe
Details: slides 5-6-7
Change: increase error threshold for the QTest from 6 to 7 (L1 mean cluster size)
Cluster charge (BPix and FPix):
Issue: 2024 pp runs have cluster charge close to error threshold (values established 5 years ago, during Run 2)
GUI plot: https://tinyurl.com/22n2bwvv
GUI summary: https://tinyurl.com/2xn3uu59
Details: slides 2-3-4
Change: reduce error threshold to 15k electrons (BPix and FPix mean cluster charge)
PR validation:
Simple change to config numerical values: no validation done
About backport
This is a backport to 14_0_X of #45840