Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QTest Pixel DQM (BP to [14_0_X]) #45841

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

alaperto
Copy link
Contributor

PR description:

Changes to Pixel DQM Quality Test

  1. L1 cluster size:
    Issue: HI runs from 2023 and early 2024 pp runs had cluster size > 6 (outside allowed range)
    GUI plot: https://tinyurl.com/2ccppw6k
    GUI summary: https://tinyurl.com/2dysgbhe
    Details: slides 5-6-7
    Change: increase error threshold for the QTest from 6 to 7 (L1 mean cluster size)

  2. Cluster charge (BPix and FPix):
    Issue: 2024 pp runs have cluster charge close to error threshold (values established 5 years ago, during Run 2)
    GUI plot: https://tinyurl.com/22n2bwvv
    GUI summary: https://tinyurl.com/2xn3uu59
    Details: slides 2-3-4
    Change: reduce error threshold to 15k electrons (BPix and FPix mean cluster charge)

PR validation:

Simple change to config numerical values: no validation done

About backport

This is a backport to 14_0_X of #45840

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2024

A new Pull Request was created by @alaperto for CMSSW_14_0_X.

It involves the following packages:

  • DQM/SiPixelPhase1Config (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild added the trk label Aug 30, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Aug 30, 2024

please test

@tjavaid
Copy link

tjavaid commented Aug 30, 2024

backport of #45840

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1613e7/41200/summary.html
COMMIT: 6b68a34
CMSSW: CMSSW_14_0_X_2024-08-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45841/41200/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@sroychow
Copy link
Contributor

sroychow commented Sep 5, 2024

ping @cms-sw/dqm-l2

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

@alaperto , @sroychow , we are testing the PR at our playback machine with Run 384377. Could you please have a look at GUI plots and see whether changes are applied. Thanks!

@alaperto
Copy link
Contributor Author

alaperto commented Sep 5, 2024

Hi @tjavaid is there a reason why you're using Online Playback machine?
The changes were targeting Offline DQM GUI.
By the way, I guess the QTest (modified code) is applied also to Online Summary maps:

  • the Cluster Charge Summary appear Green, as expected from the changes
  • before the fix, it was showing Red and Orange blocks

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

I guess the QTest (modified code) is applied also to Online Summary maps:

Hi @alaperto , yes. That's also my perception that it also propagates to the Online Summary maps as I looked at the existing plots (thanks for checking from your side as well).
If you are OK with the changes to both Offline/Online plots, we can sign it now.

@alaperto
Copy link
Contributor Author

alaperto commented Sep 5, 2024

Hi @tjavaid looks great! Please, proceed.

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

Hi @tjavaid looks great! Please, proceed.

@alaperto , may I ask to edit title of the PR a bit i.e. change (BP) to [14_0_X]

@alaperto alaperto changed the title Improve QTest Pixel DQM (BP) Improve QTest Pixel DQM (BP to [14_0_X]) Sep 5, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1bf30da into cms-sw:CMSSW_14_0_X Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants