Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Update Pixel GPU DQM online client #45806

Merged
merged 7 commits into from
Aug 31, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 27, 2024

backport of #45666

PR description:

This PR performs few simple updates of the pixel GPU DQM online client:

  • fix the pixel digi error collection names for the HIon menu (CMSHLT-3284)
  • add pixel heterogeneous harvesting sequence for alpaka
  • update pixelgpu_dqm_sourceclient-live to add raw data input monitoring and track harvesting
  • add 2D scatter plot for track curvature and change matching deltaR from 0.2 to 0.02
  • improvements to SoA track monitoring plugins
  • add alpakaValidation modifier to .403 harvesting steps

PR validation:

scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45666 for 2024 HIon data-taking operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DQM/Integration (dqm)
  • DQM/SiPixelHeterogeneous (dqm)

@AdrianoDee, @antoniovagnerini, @cmsbuild, @kskovpen, @miquork, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @batinkov, @fabiocos, @fioriNTU, @francescobrivio, @idebruyn, @jandrea, @makortel, @missirol, @slomeo, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu= 12434.403, 12434.503, 12634.403

@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2024

type tracking

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ca4d3/41155/summary.html
COMMIT: dd76748
CMSSW: CMSSW_14_1_X_2024-08-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45806/41155/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Aug 27, 2024

enable gpu

@tjavaid
Copy link

tjavaid commented Aug 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ca4d3/41159/summary.html
COMMIT: dd76748
CMSSW: CMSSW_14_1_X_2024-08-27-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45806/41159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • You potentially added 57 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 69304
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 44
  • DQMHistoTests: Total successes: 69231
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 14487.710000000001 KiB( 7 files compared)
  • DQMHistoSizes: changed ( 12434.402 ): 0.444 KiB SiPixelHeterogeneous/PixelTrackAlpaka
  • DQMHistoSizes: changed ( 12434.403,... ): 4840.925 KiB SiPixelHeterogeneous/PixelTrackCompareDeviceVSHost
  • DQMHistoSizes: changed ( 12434.403,... ): 0.444 KiB SiPixelHeterogeneous/PixelTrackDevice
  • DQMHistoSizes: changed ( 12434.403,... ): 0.444 KiB SiPixelHeterogeneous/PixelTrackSerial
  • DQMHistoSizes: changed ( 12434.503 ): 4802.751 KiB SiPixelHeterogeneous/PixelTrackCompareGPUvsCPU
  • DQMHistoSizes: changed ( 12434.503 ): 0.444 KiB SiPixelHeterogeneous/PixelTrackSoACPU
  • DQMHistoSizes: changed ( 12434.503 ): 0.444 KiB SiPixelHeterogeneous/PixelTrackSoAGPU
  • Checked 28 log files, 35 edm output root files, 8 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 28, 2024

+1

@mmusich
Copy link
Contributor Author

mmusich commented Aug 30, 2024

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 kind ping

Copy link
Contributor

@AdrianoDee AdrianoDee Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note (mostly for @cms-sw/dqm-l2): in order for the Phase2 Alpaka DQM GPUvsCPU to properly work one would need to remove the RawData monitoring with the phase2_tracker modifier (see 992e347 as reference). This is true also without this PR, that is only activating the alpakaValidation(and then causing Phase2 *.403 to fail). It is not a huge issue for the release itself (since no IB wf will fail). Also, the fix commit is included in #45694 that I will backport to both 14_1_X and 14_0_X. So for me is good to go as is. I just wanted to point it out for clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, when we have a Phase-2 IT packer / unpacker (a phase-2 version of) those modules will be added back.

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5a9a3d7 into cms-sw:CMSSW_14_1_X Aug 31, 2024
28 checks passed
@mmusich mmusich deleted the mm_dev_update_pixelGPUclient branch August 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants