Remove Duplicate RelVals from `relval_highstats.py` and Smaller Queries for `das-up-to-nevents.py` #45774

AdrianoDee · 2024-08-22T08:09:33Z

PR description:

This PR proposes few things:

to remove the duplicate RelVals in relval_highstats.py already added in relval_data_highstats.py by 2024 Data RelVals and InputInfo Events Skimming (actually) Working #45055. Without this runTheMatrix.py -w data,highstats -n complains about duplicates:

==> duplicate name found for  2024.4141_RunZeroBias2024F_1M
    keeping  :  (2024.4141, 'RunZeroBias2024F_1M', [<Configuration.PyReleaseValidation.MatrixUtil.InputInfo object at 0x7f2bcc55d700>, 'cmsDriver.py step2  --process reHLT -s L1REPACK:Full,HLT:@relval2024 --conditions auto:run3_hlt_relval --data  --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3_2024', 'cmsDriver.py step3  --conditions auto:run3_data_prompt_relval -s RAW2DIGI,L1Reco,RECO,PAT,NANO,DQM:@standardDQM+@miniAODDQM+@nanoAODDQM --datatier AOD,MINIAOD,NANOAOD,DQMIO --eventcontent AOD,MINIAOD,NANOEDMAOD,DQM --data  --process reRECO --scenario pp --era Run3 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3 --hltProcess reHLT', 'cmsDriver.py step4  -s HARVESTING:@standardDQM+@miniAODDQM+@nanoAODDQM --conditions auto:run3_data --data  --filetype DQM --scenario pp --era Run3'], ['RunZeroBias2024F_1M', 'HLTDR3_2024', 'AODNANORUN3_reHLT_2024', 'HARVESTRUN3_2024'])
    ignoring :  (2024.4141, 'RunZeroBias2024F_1M', [<Configuration.PyReleaseValidation.MatrixUtil.InputInfo object at 0x7f2bcc55d700>, 'cmsDriver.py step2  --process reHLT -s L1REPACK:Full,HLT:@relval2024 --conditions auto:run3_hlt_relval --data  --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3_2024', 'cmsDriver.py step3  --conditions auto:run3_data_prompt_relval -s RAW2DIGI,L1Reco,RECO,PAT,NANO,DQM:@standardDQM+@miniAODDQM+@nanoAODDQM --datatier AOD,MINIAOD,NANOAOD,DQMIO --eventcontent AOD,MINIAOD,NANOEDMAOD,DQM --data  --process reRECO --scenario pp --era Run3 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3 --hltProcess reHLT', 'cmsDriver.py step4  -s HARVESTING:@standardDQM+@miniAODDQM+@nanoAODDQM --conditions auto:run3_data --data  --filetype DQM --scenario pp --era Run3'], ['RunZeroBias2024F_1M', 'HLTDR3_2024', 'AODNANORUN3_reHLT_2024', 'HARVESTRUN3_2024'])

adjusted das-up-to-nevents.py to run DAS queries run per run up to the number of events requested in order to have smaller queries to be cached by cms-bot. This should fix the DAS query failures observed in latest tests.
moving most of the 2024 data wfs from relval_standard.py to relval_data_highstats.py so that they don't get run in the IBs (since it's not really needed). This reduce the 2024 wfs to be run in an IB from 75 to 4.

PR validation:

runTheMatrix.py -w data,highstats -n

does not complain about duplicates anymore.

cmsbuild · 2024-08-22T08:09:58Z

cms-bot internal usage

cmsbuild · 2024-08-22T08:11:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45774/41490

cmsbuild · 2024-08-22T08:11:42Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-08-22T08:11:44Z

type bug-fix

AdrianoDee · 2024-08-22T08:11:47Z

please test

cmsbuild · 2024-08-23T08:39:43Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d210fa/41078/summary.html
COMMIT: 014fc82
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45774/41078/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2024.2010052024.201005_RunDisplacedJet2024D_50k/step1_dasquery.log
2024.201005DAS Error

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 100 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328166
DQMHistoTests: Total failures: 2846
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3325300
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-08-23T09:09:46Z

please test

cmsbuild · 2024-08-23T12:11:22Z

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d210fa/41094/summary.html
COMMIT: 014fc82
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45774/41094/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

2024.1050052024.105005_RunMuon02024C_50k/step1_dasquery.log
2024.1110052024.111005_RunParkingSingleMuon02024C_50k/step1_dasquery.log
2024.1070052024.107005_RunNoBPTX2024C_50k/step1_dasquery.log

Expand to see more relval errors ...

2024.201005
2024.312005
2024.400005
2024.406005
2024.401005
2024.402005
2024.413005
2024.105005
2024.107005
2024.111005
2024.201005
2024.312005
2024.400005
2024.401005
2024.402005
2024.406005
2024.413005

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328166
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328143
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-08-24T20:43:26Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d210fa/41118/summary.html
COMMIT: ea90f7e
CMSSW: CMSSW_14_1_X_2024-08-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45774/41118/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 104 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328202
DQMHistoTests: Total failures: 2846
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3325336
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-08-25T09:05:56Z

please test

It seems to me the unit test failure is unrelated and I can't reproduce it offline (not even using the cms-bot DAS client).

cmsbuild · 2024-08-25T15:36:40Z

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d210fa/41120/summary.html
COMMIT: ea90f7e
CMSSW: CMSSW_14_1_X_2024-08-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45774/41120/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 13 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328202
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328171
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

mmusich · 2024-08-26T06:21:56Z

urgent

to remove IB and PR tests failures

srimanob · 2024-08-26T06:39:06Z

+Upgrade

AdrianoDee · 2024-08-26T07:25:12Z

+pdmv

cmsbuild · 2024-08-26T07:25:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-08-26T07:36:33Z

+1

Remove Duplicate RelVals from relval_highstats.py

014fc82

cmsbuild added this to the CMSSW_14_1_X milestone Aug 22, 2024

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Aug 22, 2024

AdrianoDee marked this pull request as ready for review August 22, 2024 08:11

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 22, 2024

cmsbuild added bug-fix tests-started and removed tests-pending labels Aug 22, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 23, 2024

cmsbuild added tests-started and removed tests-rejected labels Aug 23, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 23, 2024

Fix to dasgoclient queries

58a6ac5

cmsbuild removed the tests-rejected label Aug 24, 2024

cmsbuild added tests-started and removed tests-pending labels Aug 24, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 24, 2024

cmsbuild added tests-started and removed tests-rejected labels Aug 25, 2024

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2024

This was referenced Aug 25, 2024

Update to relval_gpu.pyfor Alpaka and Pixel Triplets Alpaka Workflows #45694

Merged

add a phase-2 D110 relval workflow running the HLT timing menu, up to step2 #45776

Merged

cmsbuild added the urgent label Aug 26, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Aug 26, 2024

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Aug 26, 2024

cmsbuild added orp-approved and removed orp-pending labels Aug 26, 2024

cmsbuild merged commit 3914bc8 into cms-sw:master Aug 26, 2024
11 checks passed

AdrianoDee deleted the patch-14 branch August 27, 2024 06:38

ggonzr mentioned this pull request Aug 30, 2024

Add data Option for Matrix cms-PdmV/RelVal#130

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Duplicate RelVals from `relval_highstats.py` and Smaller Queries for `das-up-to-nevents.py` #45774

Remove Duplicate RelVals from `relval_highstats.py` and Smaller Queries for `das-up-to-nevents.py` #45774

AdrianoDee commented Aug 22, 2024 •

edited

Loading

cmsbuild commented Aug 22, 2024 •

edited

Loading

cmsbuild commented Aug 22, 2024

cmsbuild commented Aug 22, 2024

AdrianoDee commented Aug 22, 2024

AdrianoDee commented Aug 22, 2024

cmsbuild commented Aug 23, 2024

AdrianoDee commented Aug 23, 2024

cmsbuild commented Aug 23, 2024

cmsbuild commented Aug 24, 2024

AdrianoDee commented Aug 25, 2024

cmsbuild commented Aug 25, 2024

mmusich commented Aug 26, 2024

srimanob commented Aug 26, 2024

AdrianoDee commented Aug 26, 2024

cmsbuild commented Aug 26, 2024

mandrenguyen commented Aug 26, 2024

Remove Duplicate RelVals from relval_highstats.py and Smaller Queries for das-up-to-nevents.py #45774

Remove Duplicate RelVals from relval_highstats.py and Smaller Queries for das-up-to-nevents.py #45774

Conversation

AdrianoDee commented Aug 22, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Aug 22, 2024 • edited Loading

cmsbuild commented Aug 22, 2024

cmsbuild commented Aug 22, 2024

AdrianoDee commented Aug 22, 2024

AdrianoDee commented Aug 22, 2024

cmsbuild commented Aug 23, 2024

RelVals-INPUT

Comparison Summary

AdrianoDee commented Aug 23, 2024

cmsbuild commented Aug 23, 2024

Unit Tests

RelVals-INPUT

Comparison Summary

cmsbuild commented Aug 24, 2024

Unit Tests

Comparison Summary

AdrianoDee commented Aug 25, 2024

cmsbuild commented Aug 25, 2024

Comparison Summary

mmusich commented Aug 26, 2024

srimanob commented Aug 26, 2024

AdrianoDee commented Aug 26, 2024

cmsbuild commented Aug 26, 2024

mandrenguyen commented Aug 26, 2024

Remove Duplicate RelVals from `relval_highstats.py` and Smaller Queries for `das-up-to-nevents.py` #45774

Remove Duplicate RelVals from `relval_highstats.py` and Smaller Queries for `das-up-to-nevents.py` #45774

AdrianoDee commented Aug 22, 2024 •

edited

Loading

cmsbuild commented Aug 22, 2024 •

edited

Loading