Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BTV, NanoAOD] Add UParT discriminants for strange-jet tagging #45684

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Aug 9, 2024

PR description:

This PR defines the UParT discriminants for strange jet tagging (SvsUDG , SvsCB) and store them in NanoAOD (and JMENano) for AK4 jets. The sum of u, d and g raw scores (UDG) is also stored, which can be used to re-calculate the raw scores. These new branches are for the NanoAODv15 campaign.

The UParT strange jet tagging performance is documented in a recently released DP-note (CMS-DP-2024-066 Figure 4)

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
  • ran workflow 141.044_RunJetMET2023D and had checked that the new discriminants and scores are in MiniAOD and NanoAOD

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2024

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • RecoBTag/ONNXRuntime (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @gpetruc, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42bce6/40854/summary.html
COMMIT: 5451836
CMSSW: CMSSW_14_1_X_2024-08-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45684/40854/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 298 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422822
  • DQMHistoTests: Total failures: 2464
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420338
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26.925999999999988 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 2.170 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 1.304 KiB Physics/NanoAODDQM
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

nurfikri89 is there some documentation of the performance you can add to the PR description?

@mandrenguyen
Copy link
Contributor

enable nano
sorry, should have done it the first time

@mandrenguyen
Copy link
Contributor

@nurfikri89
Copy link
Contributor Author

nurfikri89 is there some documentation of the performance you can add to the PR description?

@mandrenguyen I have added a link to the DP-note which documents the performance of UParT.

There are some differences in the comparisons that are not obviously expected for me. Why are SVs now empty, e.g.? https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-08-09-1100+42bce6/63954/validateJR/25202.0_TTbar_13/all_NANO_step5/c_nanoaodFlatTable_jetPuppiTable__NANO_obj_floats__nSVs_304.png

Hmm it is not clear to me also. I will try to take a look at them with a local test on lxplus.

@vlimant
Copy link
Contributor

vlimant commented Aug 12, 2024

please test
(with nano now)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42bce6/40863/summary.html
COMMIT: 5451836
CMSSW: CMSSW_14_1_X_2024-08-11-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45684/40863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 216 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422822
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422799
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26.925999999999988 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 2.170 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 1.304 KiB Physics/NanoAODDQM
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 507 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54913
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54913
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.977999999999998 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 2.170 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 1.304 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.825 2.785 0.040 ( +1.4% ) 3.33 3.33 +0.0% 6.029 6.024
2500.002 2.941 2.898 0.043 ( +1.5% ) 2.97 2.95 +0.8% 6.398 6.363
2500.003 2.886 2.844 0.042 ( +1.5% ) 3.08 3.04 +1.5% 6.351 6.342
2500.011 1.477 1.447 0.030 ( +2.0% ) 5.83 5.74 +1.6% 2.203 2.396
2500.012 1.945 1.907 0.038 ( +2.0% ) 3.15 3.13 +0.5% 2.382 2.585
2500.013 1.794 1.762 0.032 ( +1.8% ) 4.56 4.55 +0.1% 2.493 2.478
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.96 0.95 +0.6% 2.197 2.195
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.95 0.91 +4.0% 2.211 2.193
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.93 0.92 +2.1% 2.168 2.144
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.69 0.68 +1.8% 2.305 2.314
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.88 0.87 +1.2% 2.309 2.280
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.90 0.88 +2.0% 2.255 2.227
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.81 0.80 +1.9% 2.360 2.322
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.81 0.80 +0.9% 2.333 2.308
2500.101 2.648 2.643 0.005 ( +0.2% ) 8.90 8.79 +1.3% 6.262 6.271
2500.111 1.330 1.327 0.003 ( +0.2% ) 19.69 19.74 -0.3% 1.993 2.123
2500.112 1.735 1.732 0.003 ( +0.2% ) 15.15 15.02 +0.9% 2.102 2.083
2500.131 5.194 5.194 0.000 ( +0.0% ) 15.48 15.49 -0.0% 1.544 1.497
2500.201 2.479 2.475 0.004 ( +0.1% ) 7.49 7.41 +1.1% 5.497 5.450
2500.211 1.599 1.589 0.010 ( +0.7% ) 17.42 17.11 +1.8% 2.077 2.061
2500.212 2.041 2.030 0.011 ( +0.5% ) 13.69 13.71 -0.2% 2.129 2.093
2500.221 2.006 2.006 0.000 ( +0.0% ) 7.85 7.47 +5.2% 2.260 2.230
2500.222 3.076 3.072 0.005 ( +0.1% ) 7.66 7.39 +3.7% 2.321 2.300
2500.223 8.889 8.885 0.005 ( +0.1% ) 2.79 2.79 +0.1% 2.185 2.312
2500.224 5.557 5.512 0.046 ( +0.8% ) 1.10 1.07 +2.6% 1.973 2.127
2500.225 5.577 5.530 0.047 ( +0.8% ) 1.02 0.99 +2.9% 1.955 2.059
2500.226 2.975 2.970 0.005 ( +0.2% ) 7.58 7.32 +3.6% 2.301 2.292
2500.227 8.972 8.972 0.000 ( +0.0% ) 10.23 9.99 +2.4% 1.374 1.391
2500.231 1.407 1.407 0.000 ( +0.0% ) 13.67 13.68 -0.1% 1.670 1.945
2500.232 2.156 2.145 0.011 ( +0.5% ) 13.48 13.45 +0.2% 2.016 2.005
2500.233 4.678 4.668 0.011 ( +0.2% ) 4.67 4.77 -2.1% 1.785 1.753
2500.234 3.334 3.304 0.029 ( +0.9% ) 1.48 1.48 +0.1% 1.779 1.781
2500.235 3.344 3.315 0.030 ( +0.9% ) 1.38 1.38 +0.0% 1.473 1.796
2500.236 2.093 2.082 0.011 ( +0.5% ) 13.60 12.93 +5.1% 1.991 2.023
2500.237 7.977 7.977 0.000 ( +0.0% ) 14.55 14.33 +1.5% 1.391 1.389
2500.241 9.405 9.405 0.000 ( +0.0% ) 3.97 3.83 +3.8% 1.761 1.882
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.90 0.85 +5.6% 1.724 1.254
2500.243 2.712 2.712 0.000 ( +0.0% ) 6.94 7.54 -8.0% 1.056 1.056
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.56 0.53 +4.8% 1.595 1.280
2500.245 823.224 823.224 0.000 ( +0.0% ) 0.75 0.73 +2.4% 1.575 1.523
2500.901 1.749 1.749 0.000 ( +0.0% ) 21.40 18.11 +18.2% 1.828 1.791
2500.902 1.598 1.598 0.000 ( +0.0% ) 21.59 21.02 +2.7% 1.251 1.749
2500.911 13.931 13.931 0.000 ( +0.0% ) 2.87 3.14 -8.6% 1.076 1.035
2500.912 0.310 0.310 0.000 ( +0.0% ) 1.60 1.37 +16.7% 0.960 0.965
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.18 1.18 +0.2% 0.967 0.960

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42bce6/41160/summary.html
COMMIT: 5451836
CMSSW: CMSSW_14_1_X_2024-08-27-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45684/41160/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 213 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328168
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26.925999999999988 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 2.170 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 1.304 KiB Physics/NanoAODDQM
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1338 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 32 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54921
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54921
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.977999999999998 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 2.170 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 1.304 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.828 2.788 0.040 ( +1.4% ) 3.34 3.28 +1.8% 6.057 6.673
2500.002 2.944 2.901 0.043 ( +1.5% ) 2.97 2.92 +1.6% 6.409 7.029
2500.003 2.890 2.848 0.042 ( +1.5% ) 3.09 3.03 +2.2% 6.383 6.993
2500.011 1.480 1.450 0.030 ( +2.1% ) 5.73 5.54 +3.4% 2.137 2.403
2500.012 1.947 1.909 0.038 ( +2.0% ) 3.15 3.09 +2.2% 2.170 2.594
2500.013 1.797 1.765 0.032 ( +1.8% ) 4.54 4.43 +2.6% 2.190 2.501
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.84 0.95 -11.5% 2.215 2.375
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.84 0.92 -9.1% 2.222 2.370
2500.023 0.022 0.022 0.000 ( +0.2% ) 0.81 0.91 -10.8% 2.157 2.239
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.64 0.68 -6.4% 2.208 2.464
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.80 0.85 -6.2% 2.250 2.427
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.80 0.88 -8.2% 2.258 2.403
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.73 0.72 +0.6% 2.281 2.483
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.74 0.80 -7.5% 2.258 2.460
2500.101 2.650 2.646 0.004 ( +0.2% ) 9.04 8.47 +6.7% 6.279 6.939
2500.111 1.332 1.330 0.003 ( +0.2% ) 19.14 18.35 +4.3% 2.215 2.213
2500.112 1.738 1.735 0.003 ( +0.2% ) 14.74 14.22 +3.6% 2.129 2.304
2500.131 5.194 5.194 0.000 ( +0.0% ) 15.83 14.95 +5.9% 1.536 1.552
2500.201 2.482 2.478 0.004 ( +0.1% ) 7.70 7.38 +4.4% 6.121 6.216
2500.211 1.602 1.592 0.010 ( +0.6% ) 11.44 16.26 -29.7% 2.113 2.289
2500.212 2.044 2.033 0.011 ( +0.5% ) 13.43 13.22 +1.6% 2.165 2.389
2500.221 2.006 2.006 0.000 ( +0.0% ) 7.63 7.44 +2.5% 2.262 2.437
2500.222 3.076 3.072 0.005 ( +0.1% ) 7.53 7.22 +4.3% 2.330 2.523
2500.223 8.893 8.888 0.005 ( +0.1% ) 2.80 2.68 +4.4% 2.323 2.541
2500.224 5.561 5.515 0.046 ( +0.8% ) 1.12 1.05 +6.2% 2.499 2.576
2500.225 5.580 5.533 0.047 ( +0.8% ) 1.01 0.98 +3.9% 2.426 2.606
2500.226 2.978 2.973 0.005 ( +0.2% ) 7.44 7.23 +2.9% 2.294 2.522
2500.227 8.972 8.972 0.000 ( +0.0% ) 10.14 9.62 +5.4% 1.396 1.494
2500.231 1.407 1.407 0.000 ( +0.0% ) 13.16 12.69 +3.7% 1.931 2.196
2500.232 2.156 2.145 0.011 ( +0.5% ) 13.28 12.73 +4.4% 1.994 2.288
2500.233 4.681 4.670 0.011 ( +0.2% ) 4.88 4.65 +4.8% 2.021 2.307
2500.234 3.336 3.307 0.029 ( +0.9% ) 1.49 1.42 +5.0% 2.055 2.327
2500.235 3.347 3.317 0.030 ( +0.9% ) 1.39 1.35 +2.6% 2.074 2.345
2500.236 2.096 2.085 0.011 ( +0.5% ) 13.14 12.85 +2.3% 2.018 2.279
2500.237 7.977 7.977 0.000 ( +0.0% ) 14.35 14.14 +1.5% 1.435 1.572
2500.241 9.405 9.405 0.000 ( +0.0% ) 3.85 3.55 +8.4% 1.850 1.959
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.91 0.83 +8.9% 1.672 1.724
2500.243 2.712 2.712 0.000 ( +0.0% ) 7.24 6.66 +8.7% 1.058 1.059
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.56 0.53 +5.8% 1.680 1.668
2500.245 823.224 823.224 0.000 ( +0.0% ) 0.74 0.70 +5.6% 1.570 1.666
2500.901 1.749 1.749 0.000 ( +0.0% ) 20.78 20.26 +2.6% 1.756 1.830
2500.902 1.598 1.598 0.000 ( +0.0% ) 21.78 20.67 +5.3% 1.756 1.757
2500.911 13.931 13.931 0.000 ( +0.0% ) 3.18 2.83 +12.3% 1.078 1.079
2500.912 0.437 0.310 0.126 ( +40.7% ) 1.22 1.33 -7.7% 0.966 0.970
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.17 1.12 +3.7% 0.966 0.974

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

hold
I think we're still waiting for an answer to this:
#45684 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@hqucms
Copy link
Contributor

hqucms commented Sep 3, 2024

hold I think we're still waiting for an answer to this: #45684 (comment)

@mandrenguyen I think it's not a real difference, just that the order of variables in the nano flat table changed because of the new variables?

@mandrenguyen
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 369cd7c into cms-sw:master Sep 3, 2024
13 checks passed
@nurfikri89 nurfikri89 deleted the from1410pre6_addUPartTStrangeTag branch September 16, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants