Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty classes_def file from DPGAnalysis/HcalNanoAOD #45583

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

makortel
Copy link
Contributor

PR description:

duplicateReflexLibrarySearch.py was indicating this file "did not have the proper information", and upon closer look, they are effectively empty, and can thus be removed.

Resolves cms-sw/framework-team#971

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DPGAnalysis/HcalNanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

type -changes-dataformats

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-574181/40683/summary.html
COMMIT: 4068b2a
CMSSW: CMSSW_14_1_X_2024-07-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45583/40683/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@vlimant
Copy link
Contributor

vlimant commented Jul 30, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor Author

Comparison differences are related to #39803

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3244058 into cms-sw:master Jul 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove empty classes_def file from DPGAnalysis/HcalNanoAOD
4 participants