Add dictionary for AbsHcalAlgoData

[makortel]

PR description:

Dictionary for AbsHcalAlgoData is required to get the version and checksum of HFPhase1PMTParams. I also cleaned up classes.h. Found with #45423 (comment)

Resolves cms-sw/framework-team#963

PR validation:

Code compiles, and the to-be-added edmDumpClassVersion succeeds to process the classes_def.xml files.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45553/41034

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• CondFormats/HcalObjects (alca, db)

@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @abdoulline, @bsunanda, @mmusich, @rsreds, @seemasharmafnal, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmabuild, please test

[makortel]

type -changes-dataformats

[perrotta]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9de16/40685/summary.html
COMMIT: 3d74617
CMSSW: CMSSW_14_1_X_2024-07-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45553/40685/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 167 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 308
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3423633
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #45505

[perrotta]

@igv4321 @bsunanda @kpedro88 (adding a few names from the latest developers of this file): do you foresee any possible usage of the namespace CondFormats_HcalObjects which is cleaned up here? As far as I can see it can be removed, but please confirm.

[makortel]

do you foresee any possible usage of the namespace CondFormats_HcalObjects which is cleaned up here

Just to note that this part in the classes.h was needed at the time (ROOT5 era or something), but has been unnecessary for a long time now (for the purposes of ROOT dictionary generation).

[perrotta]

do you foresee any possible usage of the namespace CondFormats_HcalObjects which is cleaned up here

Just to note that this part in the classes.h was needed at the time (ROOT5 era or something), but has been unnecessary for a long time now (for the purposes of ROOT dictionary generation).

Thank you @makortel, that's fine with me.
Then, does it mean that all those namespace's should also better get cleaned up now?

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

Then, does it mean that all those namespace's should also better get cleaned up now?

Yes, all of those can be cleaned up (I'm somewhat surprised there are that many left)

[mandrenguyen]

+1