Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1Ntuple customisation for MiniAOD #45543

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

artlbv
Copy link
Contributor

@artlbv artlbv commented Jul 24, 2024

PR description:

This adds a customisation for the L1Ntupler to run on MiniAOD files, similar to this PR #45440 for NanoDST/L1Accept.

Since MiniAOD stores only the unpacked objects, only the corresponding trees are created:

BXVector<GlobalAlgBlk>                "gtStage2Digis"             ""                "RECO"    
BXVector<GlobalExtBlk>                "gtStage2Digis"             ""                "RECO"    
BXVector<GlobalExtBlk>                "simGtExtUnprefireable"     ""                "RECO"    
BXVector<l1t::EGamma>                 "caloStage2Digis"           "EGamma"          "RECO"    
BXVector<l1t::EtSum>                  "caloStage2Digis"           "EtSum"           "RECO"    
BXVector<l1t::Jet>                    "caloStage2Digis"           "Jet"             "RECO"    
BXVector<l1t::Muon>                   "gmtStage2Digis"            "Muon"            "RECO"    
BXVector<l1t::Tau>                    "caloStage2Digis"           "Tau"             "RECO"    

PR validation:

Used this cmsDriver in CMSSW_14_1_0_pre5:

cmsDriver.py l1Ntuple -s NANO,USER:L1Trigger/L1TNtuples/L1NtupleMINI_cff.L1NtupleMINI \ 
-n 10000 --eventcontent NANOAOD --era=Run3 --data --conditions=140X_dataRun3_Prompt_v2 \
--customise=L1Trigger/L1TNtuples/customiseL1Ntuple.L1NtupleMINI,PhysicsTools/NanoAOD/l1trig_cff.nanoL1TrigObjCustomizeFull --filein file:/eos/cms/tier0/store/data/Run2024F/JetMET1/MINIAOD/PromptReco-v1/000/383/447/00000/0326688d-c840-43a9-96a7-98ff241fb155.root

Which produced L1 menu ntuples and Nano with the same content of L1 objects.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport planned.

FYI @caruta @eyigitba @slaurila @RobertJWard

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @artlbv for master.

It involves the following packages:

  • L1Trigger/L1TNtuples (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @kreczko, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18ab35/40584/summary.html
COMMIT: 672fa91
CMSSW: CMSSW_14_1_X_2024-07-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45543/40584/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2500.2452500.245_hcalDPGCalibNANO140Xrun3/step2_hcalDPGCalibNANO140Xrun3.log

Comparison Summary

Summary:

@epalencia
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18ab35/40647/summary.html
COMMIT: 672fa91
CMSSW: CMSSW_14_1_X_2024-07-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45543/40647/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423961
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423932
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cf6532a into cms-sw:master Jul 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants