Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test TestPerfToolsModuleAllocMonitor for ASAN IBs #45509

Merged

Conversation

aandvalenzuela
Copy link
Contributor

Hello,

Test TestPerfToolsModuleAllocMonitor is failing in ASAN IBs with:

===== Test "TestPerfToolsModuleAllocMonitor" ====
+ LOCAL_TEST_DIR=/data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_14_1_ASAN_X_2024-07-17-2300/src/PerfTools/AllocMonitor/test
+ LD_PRELOAD=libPerfToolsAllocMonitorPreload.so
+ cmsRun /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_14_1_ASAN_X_2024-07-17-2300/src/PerfTools/AllocMonitor/test/moduleAlloc_cfg.py
==1927315==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.
+ die 'Failure using moduleAlloc_cfg.py' 1
+ echo Failure using moduleAlloc_cfg.py: status 1
Failure using moduleAlloc_cfg.py: status 1
+ exit 1

---> test TestPerfToolsModuleAllocMonitor had ERRORS
TestTime:0
^^^^ End Test TestPerfToolsModuleAllocMonitor ^^^^

After discussing with @smuzaffar, we propose disabling this test for ASAN since the job configures its own LD_PRELOAD. See https://github.com/cms-sw/cmssw/blob/master/PerfTools/AllocMonitor/test/runModuleAlloc.sh.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela for master.

It involves the following packages:

  • PerfTools/AllocMonitor (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @makortel this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test for CMSSW_14_1_ASAN_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25bffc/40493/summary.html
COMMIT: 4a8c5ba
CMSSW: CMSSW_14_1_ASAN_X_2024-07-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45509/40493/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 29700.029700.0_CloseByPGun_CE_H_Coarse_Scint+2026D110/step2_CloseByPGun_CE_H_Coarse_Scint+2026D110.log
  • 29696.029696.0_CloseByPGun_CE_E_Front_120um+2026D110/step2_CloseByPGun_CE_E_Front_120um+2026D110.log
  • 29634.029634.0_TTbar_14TeV+2026D110/step2_TTbar_14TeV+2026D110.log
Expand to see more relval errors ...

@makortel
Copy link
Contributor

The test confirms the unit test is not run in ASAN

@makortel
Copy link
Contributor

@cmsbuild, please test

Let's test default IB too

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25bffc/40498/summary.html
COMMIT: 4a8c5ba
CMSSW: CMSSW_14_1_X_2024-07-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45509/40498/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345208
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345185
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4241872 into cms-sw:master Jul 22, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants