[CLANG] Phase2L1GT: Fix compilation warnings

[smuzaffar]

This PR fixes compilation warnings [a] for CLANG IB

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-17-1700/L1Trigger/Phase2L1GT

• remove std::move

  src/L1Trigger/Phase2L1GT/plugins/L1GTOutputObjectWriter.cc:272:40: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
   272 |   outputObjects.emplace("GCTNonIsoEg", std::move(fillCollection<L1TGT_Common3Vector<64>>(event, gctNonIsoEgToken_)));
      |                                        ^
src/L1Trigger/Phase2L1GT/plugins/L1GTOutputObjectWriter.cc:272:40: note: remove std::move call here
  272 |   outputObjects.emplace("GCTNonIsoEg", std::move(fillCollection<L1TGT_Common3Vector<64>>(event, gctNonIsoEgToken_)));

• overridden virtual function but is not marked 'override'

  src/L1Trigger/Phase2L1GT/plugins/L1GTAlgoBlockProducer.cc:340:8: warning: 'globalEndRun' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
   340 |   void globalEndRun(edm::Run const&, edm::EventSetup const&) {}
      |        ^
src/FWCore/Framework/interface/one/implementors.h:290:22: note: overridden virtual function is here
  290 |         virtual void globalEndRun(edm::Run const&, edm::EventSetup const&) = 0;

[smuzaffar]

please test for CMSSW_14_1_CLANG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45495/40964

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• L1Trigger/Phase2L1GT (upgrade, l1)

@aloeliger, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86b3e/40474/summary.html
COMMIT: d1fede2
CMSSW: CMSSW_14_1_CLANG_X_2024-07-17-1700/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45495/40474/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 13792 lines to the logs
• Reco comparison results: 36749 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 35219
• DQMHistoTests: Total nulls: 120
• DQMHistoTests: Total successes: 3309849
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.05 KiB( 47 files compared)
• DQMHistoSizes: changed ( 140.043 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.063 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): 0.043 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 7 / 46 workflows

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d86b3e/40482/summary.html
COMMIT: d1fede2
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45495/40482/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 253 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 2769
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342419
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[iarspider]

Fixes #45390

[srimanob]

The non-reproducibility show up here, as mentioned in the issue #45505

@smuzaffar How are the reference and target made in the PR test? Thx.

[srimanob]

+Upgrade

We can ignore .7 and .911 for now.

[smuzaffar]

@smuzaffar How are the reference and target made in the PR test? Thx.

Ref for both CLANG tests was generated using production arch IB CMSSW_14_1_X_2024-07-17-1700 and for default tests production arch IB CMSSW_14_1_X_2024-07-18-1100 was used

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1