Cond: Remove unused variables

[smuzaffar]

This change commented out few variables which are not used any more ( or used in a comment only). This should the warnings like [a] for CLANG IBs

[a]

• https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-17-1700/CondCore/CondDB
• https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-17-1700/CondTools/RunInfo

  src/CondCore/CondDB/src/DecodingKey.cc:27:26: warning: unused variable 'DATEPREFIX' [-Wunused-const-variable]
    27 | static const std::string DATEPREFIX("D=");

  src/CondTools/RunInfo/src/RunInfoRead.cc:26:21: warning: unused variable 'dot' [-Wunused-const-variable]
    26 |   const std::string dot(".");
      |                     ^~~
  src/CondTools/RunInfo/src/RunInfoRead.cc:28:21: warning: unused variable 'bNOTb' [-Wunused-const-variable]
    28 |   const std::string bNOTb(" NOT ");

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45493/40963

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• CondCore/CondDB (db)
• CondTools/RunInfo (db)

@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test for CMSSW_14_1_CLANG_X

[smuzaffar]

please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56bc77/40472/summary.html
COMMIT: 663dd17
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45493/40472/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 167 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 308
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344880
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56bc77/40471/summary.html
COMMIT: 663dd17
CMSSW: CMSSW_14_1_CLANG_X_2024-07-17-1700/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45493/40471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 13792 lines to the logs
• Reco comparison results: 36736 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 35219
• DQMHistoTests: Total nulls: 120
• DQMHistoTests: Total successes: 3309849
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.05 KiB( 47 files compared)
• DQMHistoSizes: changed ( 140.043 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.063 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): 0.043 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 7 / 46 workflows

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56bc77/40483/summary.html
COMMIT: 663dd17
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45493/40483/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 160 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 302
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344886
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1