Fix pixel CPE position [14.0.x]

[fwyzard]

PR description:

Rewrite the pixel CPE position calculation to improve the reproducibility of the results.

Fix the includes used in DataFormats/TrackingRecHitSoA to avoid the dependency on RecoLocalTracker/SiPixelRecHits.

Thanks to @missirol for spotitng the source of the discrepancy.

PR validation:

Tested on top of CMSSW 14.0.11 running the HLT over 100k events:

• the CPU-only results are reproducible, with and without these changes;
• the GPU vs CPU results are in general slightly more reproducible;
• the biggest improvement is fixing the reproducibility of HLT_SingleEle8_v7, going from 2% of the accepted events to being fully reproducible.

GPU vs CPU results, without these changes

• +4/-5 events in HLT_SingleEle8_v7 (2% of the accepted events)
• +/-4 events in 1 path
• +/-3 events in 2 paths
• +/-2 events in 6 paths
• +/-1 event in 59 paths

GPU vs CPU results, with these changes

• +/-3 events in 2 paths
• +/-2 events in 12 paths
• +/-1 event in 46 paths

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45471 to 14.0.x for data taking.

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

• DataFormats/TrackingRecHitSoA (reconstruction, heterogeneous)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix pixel CPE position #45471

[cmsbuild]

cms-bot internal usage

[fwyzard]

backport #45471

[fwyzard]

type bugfix

[fwyzard]

enable gpu

[fwyzard]

test parameters:

• enable = gpu
• workflows_gpu = 12634.402,12634.403,12634.404

[fwyzard]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6c8e8/40427/summary.html
COMMIT: 13e9f7b
CMSSW: CMSSW_14_0_X_2024-07-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45472/40427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 50 lines from the logs
• Reco comparison results: 37 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3449350
• DQMHistoTests: Total failures: 4026
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3445304
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 47 workflows

GPU Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 5
• DQMHistoTests: Total histograms compared: 71830
• DQMHistoTests: Total failures: 4434
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 67396
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
• Checked 19 log files, 22 edm output root files, 5 DQM output files
• TriggerResults: no differences found

[fwyzard]

+heterogeneous

[fwyzard]

please test

[cmsbuild]

Pull request #45472 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6c8e8/40440/summary.html
COMMIT: fa8877a
CMSSW: CMSSW_14_0_X_2024-07-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45472/40440/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 41 lines from the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3449350
• DQMHistoTests: Total failures: 4029
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3445301
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 47 workflows

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 5
• DQMHistoTests: Total histograms compared: 71830
• DQMHistoTests: Total failures: 5141
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 66689
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
• Checked 19 log files, 22 edm output root files, 5 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1