Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pythia8 Photon Flux more configurable. #45468

Merged

Conversation

hjbossi
Copy link
Contributor

@hjbossi hjbossi commented Jul 16, 2024

PR description:

Changes made to make the Pythia8 photon flux more configurable.

PR validation:

This PR is a backport of #44549 meant for the next release cycle.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2024

A new Pull Request was created by @hjbossi for CMSSW_13_0_HeavyIon_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/Pythia8Interface (generators)

@GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @cmsbuild, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @fabiocos, @missirol, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

please test workflow 180,181

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37d719/40421/summary.html
COMMIT: 4dc5e75
CMSSW: CMSSW_13_0_HeavyIon_X_2024-07-14-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45468/40421/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 180.0, 181.0

@mandrenguyen
Copy link
Contributor

test parameters

@mandrenguyen
Copy link
Contributor

please test
I forgot that 180,181 didn't exist yet in 13_0_X.
Let's see if the test parameters flag reset the extra workflows correctly.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37d719/40424/summary.html
COMMIT: 4dc5e75
CMSSW: CMSSW_13_0_HeavyIon_X_2024-07-14-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45468/40424/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283624
  • DQMHistoTests: Total failures: 989
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282613
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@hjbossi
Copy link
Contributor Author

hjbossi commented Jul 16, 2024

Can someone merge this backport as all tests were successful?

@mandrenguyen
Copy link
Contributor

backport of #44549

@mandrenguyen
Copy link
Contributor

@cms-sw/generators-l2 Please review this backport when you find a moment.

@bbilin
Copy link
Contributor

bbilin commented Jul 18, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_HeavyIon_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 61ff178 into cms-sw:CMSSW_13_0_HeavyIon_X Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants