Fix compatibility with FMT 10 #45467

iarspider · 2024-07-15T20:02:46Z

PR description:

Title says it all. When testing cms-sw/cmsdist#9293, the following errors are reported:

In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/format.h:49,
                 from src/FWCore/MessageLogger/interface/ErrorObj.h:28,
                 from src/FWCore/MessageLogger/interface/MessageSender.h:5,
                 from src/FWCore/MessageLogger/interface/MessageLogger.h:30,
                 from src/FWCore/Framework/interface/maker/Worker.h:37,
                 from src/FWCore/Framework/interface/maker/WorkerT.h:13,
                 from src/FWCore/Framework/interface/maker/WorkerMaker.h:8,
                 from src/FWCore/Framework/interface/MakerMacros.h:5,
                 from src/DQM/SiPixelHeterogeneous/plugins/SiPixelPhase1RawDataErrorComparator.cc:24:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h: In instantiation of 'constexpr fmt::v10::detail::value<Context> fmt::v10::detail::make_arg(T&) [with bool PACKED = true; Context = fmt::v10::basic_printf_context<char>; T = const {anonymous}::SiPixelFEDErrorCodes; typename std::enable_if<PACKED, int>::type <anonymous> = 0]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:1842:51:   required from 'constexpr fmt::v10::format_arg_store<Context, Args>::format_arg_store(T& ...) [with T = {const {anonymous}::SiPixelFEDErrorCodes}; Context = fmt::v10::basic_printf_context<char>; Args = {{anonymous}::SiPixelFEDErrorCodes}]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:1860:18:   required from 'constexpr fmt::v10::format_arg_store<Context, typename std::remove_cv<typename std::remove_reference<T>::type>::type ...> fmt::v10::make_format_args(T& ...) [with Context = basic_printf_context<char>; T = {const {anonymous}::SiPixelFEDErrorCodes}]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/printf.h:614:68:   required from 'std::__cxx11::basic_string<Char> fmt::v10::sprintf(const S&, const T& ...) [with S = char [14]; T = {{anonymous}::SiPixelFEDErrorCodes}; Char = char]'
src/DQM/SiPixelHeterogeneous/plugins/SiPixelPhase1RawDataErrorComparator.cc:287:61:   required from here
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:1600:63: error: 'fmt::v10::detail::type_is_unformattable_for<const {anonymous}::SiPixelFEDErrorCodes, char> _' has incomplete type
  1600 |     type_is_unformattable_for<T, typename Context::char_type> _;
      |                                                               ^
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:1604:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt
  1604 |       formattable,
      |       ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:1604:7: note: 'formattable' evaluates to false

This worked before because of a bug in fmt, where enum was silently cast to int

In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/format.h:49,
                 from src/FWCore/MessageLogger/interface/ErrorObj.h:28,
                 from src/FWCore/MessageLogger/interface/MessageSender.h:5,
                 from src/FWCore/MessageLogger/interface/MessageLogger.h:30,
                 from src/FWCore/Framework/interface/maker/Worker.h:37,
                 from src/FWCore/Framework/interface/maker/WorkerT.h:13,
                 from src/FWCore/Framework/interface/maker/WorkerMaker.h:8,
                 from src/FWCore/Framework/interface/MakerMacros.h:5,
                 from src/SimCalorimetry/HGCalAssociatorProducers/plugins/SimTauCPLinkProducer.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h: In instantiation of 'constexpr decltype (ctx.begin()) fmt::v10::detail::parse_format_specs(ParseContext&) [with T = CaloParticle; ParseContext = compile_parse_context<char>; decltype (ctx.begin()) = const char*]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2684:51:   required from here
src/SimCalorimetry/HGCalAssociatorProducers/plugins/SimTauCPLinkProducer.cc:82:40:   in 'constexpr' expansion of 'fmt::v10::basic_format_string<char, long int&, const CaloParticle&>(" CP {} {}")'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2787:40:   in 'constexpr' expansion of 'fmt::v10::detail::parse_format_string<true, char, format_string_checker<char, long int, CaloParticle> >(((fmt::v10::basic_format_string<char, long int&, const CaloParticle&>*)this)->fmt::v10::basic_format_string<char, long int&, const CaloParticle&>::str_, fmt::v10::detail::format_string_checker<char, long int, CaloParticle>(fmt::v10::basic_string_view<char>(((const char*)s))))'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2534:44:   in 'constexpr' expansion of 'fmt::v10::detail::parse_replacement_field<char, format_string_checker<char, long int, CaloParticle>&>((p + -1), end, (* & handler))'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2502:33:   in 'constexpr' expansion of '(& handler)->fmt::v10::detail::format_string_checker<char, long int, CaloParticle>::on_replacement_field((& handler)->fmt::v10::detail::format_string_checker<char, long int, CaloParticle>::on_arg_id(), begin)'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2677:20:   in 'constexpr' expansion of '((fmt::v10::detail::format_string_checker<char, long int, CaloParticle>*)this)->fmt::v10::detail::format_string_checker<char, long int, CaloParticle>::on_format_specs(id, begin, begin)'
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2593:45: error: 'fmt::v10::detail::type_is_unformattable_for<CaloParticle, char> _' has incomplete type
  2593 |     type_is_unformattable_for<T, char_type> _;
      |                                             ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h: In member function 'void SimTauProducer::buildSimTau(SimTauCPLink&, uint8_t, int, const reco::GenParticle&, int, edm::Handle<std::vector<CaloParticle> >, const std::vector<int>&) const':
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2684:51: error: 'constexpr decltype (ctx.begin()) fmt::v10::detail::parse_format_specs(ParseContext&) [with T = CaloParticle; ParseContext = compile_parse_context<char>; decltype (ctx.begin()) = const char*]' called in a constant expression
  2684 |     return id >= 0 && id < num_args ? parse_funcs_[id](context_) : begin;
      |                                       ~~~~~~~~~~~~^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-76ef466f9d9d21f087f9b7e4e843a9d9/include/fmt/core.h:2580:20: note: 'constexpr decltype (ctx.begin()) fmt::v10::detail::parse_format_specs(ParseContext&) [with T = CaloParticle; ParseContext = compile_parse_context<char>; decltype (ctx.begin()) = const char*]' is not usable as a 'constexpr' function because:
 2580 | FMT_CONSTEXPR auto parse_format_specs(ParseContext& ctx)
      |                    ^~~~~~~~~~~~~~~~~~

No idea why it stopped working. @cms-sw/simulation-l2 could you please verify that the code is supposed to print pdgId, and not some other property of CaloParticle?

PR validation:

Bot tests

cmsbuild · 2024-07-15T20:03:06Z

cms-bot internal usage

iarspider · 2024-07-15T20:03:54Z

please test

cmsbuild · 2024-07-15T20:06:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45467/40926

cmsbuild · 2024-07-15T20:06:44Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

DQM/SiPixelHeterogeneous (dqm)
SimCalorimetry/HGCalAssociatorProducers (simulation, upgrade)

@antoniovagnerini, @civanch, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fioriNTU, @idebruyn, @jandrea, @mmusich, @rovere, @sameasy, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-07-15T23:13:19Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-904835/40416/summary.html
COMMIT: 232f783
CMSSW: CMSSW_14_1_X_2024-07-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45467/40416/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 11 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345094
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345074
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

civanch · 2024-07-16T15:11:28Z

+1

srimanob · 2024-07-22T22:50:47Z

+Upgrade

srimanob · 2024-07-22T22:51:11Z

@cmsbuild please test

Refresh the test result.

cmsbuild · 2024-07-23T03:55:01Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-904835/40526/summary.html
COMMIT: 232f783
CMSSW: CMSSW_14_1_X_2024-07-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45467/40526/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 99 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345208
DQMHistoTests: Total failures: 2469
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3342719
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-07-25T07:37:39Z

please test

smuzaffar · 2024-07-25T07:40:27Z

@cms-sw/dqm-l2 , can you please review this? For DQM, it is just a technical change to us ethe correct type.
This is blocking the update of pytorch which requires new fmt version.

cmsbuild · 2024-07-25T10:56:11Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-904835/40590/summary.html
COMMIT: 232f783
CMSSW: CMSSW_14_1_X_2024-07-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45467/40590/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 97 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3325254
DQMHistoTests: Total failures: 2470
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3322764
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

tjavaid · 2024-07-25T11:56:43Z

+1

spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

cmsbuild · 2024-07-25T11:57:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2024-07-25T12:16:50Z

@cms-sw/orp-l2 , can you please include this for next 14.1.X IB. This allows us to move forward with pytorch 2.4.0

mandrenguyen · 2024-07-25T17:17:57Z

+1

Fixes for fmt 10

232f783

cmsbuild added this to the CMSSW_14_1_X milestone Jul 15, 2024

cmsbuild added simulation-pending dqm-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending trk labels Jul 15, 2024

iarspider mentioned this pull request Jul 15, 2024

[riscv] Update pytorch to version 2.4.0 cms-sw/cmsdist#9293

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2024

cmsbuild added tests-approved and removed tests-started labels Jul 15, 2024

cmsbuild added simulation-approved and removed simulation-pending labels Jul 16, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 22, 2024

cmsbuild removed the tests-approved label Jul 22, 2024

cmsbuild added the tests-started label Jul 22, 2024

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2024

cmsbuild added tests-started and removed tests-approved labels Jul 25, 2024

cmsbuild added tests-approved and removed tests-started labels Jul 25, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 25, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 25, 2024

cmsbuild merged commit 0efbba9 into cms-sw:master Jul 25, 2024
11 checks passed

cmsbuild mentioned this pull request Jul 26, 2024

remove redundant customizations in HcalNano #45561

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compatibility with FMT 10 #45467

Fix compatibility with FMT 10 #45467

iarspider commented Jul 15, 2024

cmsbuild commented Jul 15, 2024 •

edited

Loading

iarspider commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

civanch commented Jul 16, 2024

srimanob commented Jul 22, 2024

srimanob commented Jul 22, 2024

cmsbuild commented Jul 23, 2024

smuzaffar commented Jul 25, 2024

smuzaffar commented Jul 25, 2024

cmsbuild commented Jul 25, 2024

tjavaid commented Jul 25, 2024

cmsbuild commented Jul 25, 2024

smuzaffar commented Jul 25, 2024

mandrenguyen commented Jul 25, 2024

Fix compatibility with FMT 10 #45467

Fix compatibility with FMT 10 #45467

Conversation

iarspider commented Jul 15, 2024

PR description:

PR validation:

cmsbuild commented Jul 15, 2024 • edited Loading

iarspider commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

Comparison Summary

civanch commented Jul 16, 2024

srimanob commented Jul 22, 2024

srimanob commented Jul 22, 2024

cmsbuild commented Jul 23, 2024

Comparison Summary

smuzaffar commented Jul 25, 2024

smuzaffar commented Jul 25, 2024

cmsbuild commented Jul 25, 2024

Comparison Summary

tjavaid commented Jul 25, 2024

cmsbuild commented Jul 25, 2024

smuzaffar commented Jul 25, 2024

mandrenguyen commented Jul 25, 2024

cmsbuild commented Jul 15, 2024 •

edited

Loading