Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpaka modifier to HLTHgcalTiclPFClusteringForEgammaUnseededSequence #45427

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

waredjeb
Copy link
Contributor

@waredjeb waredjeb commented Jul 11, 2024

This PR is meant to fix #45426 adding the alpaka procModifier to HLTHgcalTiclPFClusteringForEgammaUnseededSequence adding the correct sequence needed after the introduction of #45178

Test

Tested on workflow 24834.402 (D98)

Would need to test on workflow with alpaka procModifier enabled, for example the *402 workflows.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @waredjeb for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @missirol, @mmusich, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2024

enable gpu

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2024

test parameters:

  • workflows = 24834.402
  • workflows_gpu = 24834.402
  • relvals_opt = --what upgrade
  • relvals_opt_gpu = --what upgrade

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2024

type hgcal, bug-fix

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2024

@cmsbuild, please test


_HLTHgcalTiclPFClusteringForEgammaUnseededSequence_heterogeneous = cms.Sequence(hgcalDigis+HGCalUncalibRecHit+HGCalRecHit+particleFlowRecHitHGC+hltHgcalSoARecHitsProducer+hltHgcalSoARecHitsLayerClustersProducer+hltHgcalSoALayerClustersProducer+hltHgCalLayerClustersFromSoAProducer+hgcalLayerClustersHSci+hgcalLayerClustersHSi+hgcalMergeLayerClusters+filteredLayerClustersCLUE3DHigh+ticlSeedingGlobal+ticlLayerTileProducer+ticlTrackstersCLUE3DHigh+particleFlowClusterHGCalFromTICLUnseeded+particleFlowSuperClusterHGCalFromTICLUnseeded)

from Configuration.ProcessModifiers.alpaka_cff import alpaka
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For internal TSG consideration, this type of pattern was already introduced at #45178, but it is somehow at odds with the current (Run3) customization paradigm. Should we consider creating a customizeHLTForCMSSW-equivalent for the phase2 menu and put there all the necessary customizations for alpaka?
That way it will be easier to remove when the alpaka modifier becomes the "norm".
I guess this also depends very much on how we want to store the phase2 menu in the long term.
@VourMa @SohamBhattacharya @fwyzard @Martin-Grunewald @missirol

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-256472/40345/summary.html
COMMIT: a44a3cd
CMSSW: CMSSW_14_1_X_2024-07-11-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45427/40345/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.402 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345074
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 204 log files, 166 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.402 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@mmusich
Copy link
Contributor

mmusich commented Jul 11, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken HLT Phase2 Simplified Menu with alpaka Modifier
4 participants