Phase2-hgx357 Give correct names of some of the variables and correct their implementation in the HGCal Geometry

[bsunanda]

PR description:

Give correct names of some of the variables and correct their implementation in the HGCal Geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45284/40677

• This PR adds an extra 108KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45284/40677/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45284/40677/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45284/40678

• This PR adds an extra 112KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• DataFormats/ForwardDetId (simulation, upgrade)
• Geometry/HGCalCommonData (upgrade, geometry)
• Geometry/HGCalGeometry (upgrade, geometry)
• L1Trigger/L1THGCal (l1, upgrade)
• SimG4CMS/Calo (simulation)
• Validation/HGCalValidation (dqm)

@mdhildreth, @bsunanda, @makortel, @rvenditti, @Dr15Jones, @civanch, @aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @syuvivida, @tjavaid, @srimanob, @nothingface0, @subirsarkar can you please review it and eventually sign? Thanks.
@slomeo, @hatakeyamak, @pfs, @cseez, @Martin-Grunewald, @lgray, @apsallid, @rovere, @missirol, @fabiocos, @mmusich, @vandreev11, @youyingli, @ReyerBand, @wang0jin, @sethzenz, @jbsauvan, @amarini, @felicepantaleo, @thomreis, @lecriste this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6a724/40019/summary.html
COMMIT: c401627
CMSSW: CMSSW_14_1_X_2024-06-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45284/40019/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345065
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[bsunanda]

@rvenditti, @aloeliger, @antoniovagnerini, @epalencia, @syuvivida, @tjavaid Please approve this PR

[aloeliger]

+l1

[tjavaid]

+1

• Fix lost Dict Def: Add HcalRecHitSoA for HcalRecHit package #45298 should fix lost dict def issue.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1