Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding various MEs to per-LS scope #45202

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Adding various MEs to per-LS scope #45202

merged 2 commits into from
Jun 20, 2024

Conversation

rseidita
Copy link
Contributor

PR description:

Adding MEs to per-LS scope for tracker, tracking, JME, and EGM

PR validation:

Tested on /Run2024D/Muon0/RAW/v1/, run 380444

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will backport to 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45202/40552

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rseidita for master.

It involves the following packages:

  • DQMServices/Core (dqm)

@cmsbuild, @antoniovagnerini, @tjavaid, @rvenditti, @syuvivida, @nothingface0 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Jun 13, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f55448/39860/summary.html
COMMIT: 7cf84cc
CMSSW: CMSSW_14_1_X_2024-06-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45202/39860/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 13-Jun-2024 07:51:48 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module METAnalyzer/'pfMetT1DQMAnalyzer'
Exception Message:
MonitorElement MET not backed by any data!
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 13-Jun-2024 07:52:33 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module METAnalyzer/'pfMetT1DQMAnalyzer'
Exception Message:
MonitorElement MET not backed by any data!
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 13-Jun-2024 07:54:58 CEST-----------------------
An exception of category 'LogicError' occurred while
   [0] Processing global end Run run: 194533
   [1] Calling method for module METAnalyzer/'pfMetT1DQMAnalyzer'
Exception Message:
MonitorElement MET not backed by any data!
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
  • 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
  • 138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45202/40650

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #45202 was updated. @cmsbuild, @rvenditti, @nothingface0, @tjavaid, @syuvivida, @antoniovagnerini can you please check and sign again.

@tjavaid
Copy link

tjavaid commented Jun 19, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f55448/39969/summary.html
COMMIT: 45d4480
CMSSW: CMSSW_14_1_X_2024-06-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45202/39969/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344998
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7ff638e into cms-sw:master Jun 20, 2024
11 checks passed
gabrielmscampos added a commit to gabrielmscampos/dials that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants