Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs #45010

bsunanda · 2024-05-21T14:51:06Z

PR description:

Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs

PR validation:

Used these files in getting calibration constants for 2024 IsoTrack studies

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

nothing special

cmsbuild · 2024-05-21T14:51:33Z

cms-bot internal usage

cmsbuild · 2024-05-21T14:56:57Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40292

Error: Found path names starting with digits: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40292/invalid-filenames.txt
This PR adds an extra 20KB to repository

cmsbuild · 2024-05-21T15:18:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40293

This PR adds an extra 20KB to repository
Found files with invalid states:
- Calibration/HcalCalibAlgos/macros/jobs/24BC.txt:
  - Added: 5923a8d
  - Deleted: bbc783d
- Calibration/HcalCalibAlgos/macros/jobs/24CC.txt:
  - Added: 5923a8d
  - Deleted: bbc783d

cmsbuild · 2024-05-21T15:19:13Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos (alca)

@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@tocheng, @rsreds, @mmusich, @yuanchao this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2024-05-21T15:43:45Z

@cmsbuild Please test

cmsbuild · 2024-05-21T18:46:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ad46/39455/summary.html
COMMIT: bbc783d
CMSSW: CMSSW_14_1_X_2024-05-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45010/39455/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 17 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 854
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3337988
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta

The suggestion below is just to make the config safer from possible typing errors.
In any case, I'd suggest to squeeze the commits, in order to get rid of the file remained with invalid state in the history.

perrotta · 2024-05-22T07:18:56Z

Calibration/HcalCalibAlgos/macros/jobs/isoTrackAlCaCommissioning_cfg.py

+process.towerMakerAll.hbheInput = cms.InputTag("hbhereco")
+process.towerMakerAll.hoInput = cms.InputTag("none")
+process.towerMakerAll.hfInput = cms.InputTag("none")
+process.towerMakerAll.ecalInputs = cms.VInputTag(cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE"))
+process.towerMakerAll.AllowMissingInputs = True


Suggested change

process.towerMakerAll.hbheInput = cms.InputTag("hbhereco")

process.towerMakerAll.hoInput = cms.InputTag("none")

process.towerMakerAll.hfInput = cms.InputTag("none")

process.towerMakerAll.ecalInputs = cms.VInputTag(cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE"))

process.towerMakerAll.AllowMissingInputs = True

process.towerMakerAll.hbheInput = "hbhereco"

process.towerMakerAll.hoInput = "none"

process.towerMakerAll.hfInput = "none"

process.towerMakerAll.ecalInputs = [cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE")]

process.towerMakerAll.AllowMissingInputs = True

or even (including only what modified wrt the original calotowermaker)

Suggested change

process.towerMakerAll.hbheInput = cms.InputTag("hbhereco")

process.towerMakerAll.hoInput = cms.InputTag("none")

process.towerMakerAll.hfInput = cms.InputTag("none")

process.towerMakerAll.ecalInputs = cms.VInputTag(cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE"))

process.towerMakerAll.AllowMissingInputs = True

process.towerMakerAll.hoInput = "none"

process.towerMakerAll.hfInput = "none"

process.towerMakerAll.AllowMissingInputs = True

cmsbuild · 2024-05-22T16:21:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40304

This PR adds an extra 20KB to repository
Found files with invalid states:
- Calibration/HcalCalibAlgos/macros/jobs/24BC.txt:
  - Added: 5923a8d
  - Deleted: bbc783d
- Calibration/HcalCalibAlgos/macros/jobs/24CC.txt:
  - Added: 5923a8d
  - Deleted: bbc783d

- Can now use tuples to set parameters that take multiple values - Improved validation of values passed to V* parameters

- denote if must use full type info when dumping to cfi - test module now makes explicit named cfi files compatible with default

…os/macros/jobs

…os/macros/jobs (restore the material from cms-sw#45010)

cmsbuild · 2024-05-26T04:12:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40349

This PR adds an extra 20KB to repository
Found files with invalid states:
- Calibration/HcalCalibAlgos/macros/jobs/24BC.txt:
  - Added: 8884866
  - Deleted: 6bc5acf
- Calibration/HcalCalibAlgos/macros/jobs/24CC.txt:
  - Added: 8884866
  - Deleted: 6bc5acf
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/CkfPattern/interface/CkfTrajectoryBuilder.h modified in PR(s): Introduce a Long-track bonus in CkfTrackBuilder #45023
- File RecoTracker/CkfPattern/plugins/TrajectorySegmentBuilder.cc modified in PR(s): Introduce a Long-track bonus in CkfTrackBuilder #45023
- File RecoTracker/CkfPattern/src/CkfTrajectoryBuilder.cc modified in PR(s): Introduce a Long-track bonus in CkfTrackBuilder #45023

cmsbuild · 2024-05-26T04:13:21Z

Pull request #45010 was updated. @cmsbuild, @saumyaphor4252, @consuegs, @mandrenguyen, @Dr15Jones, @smuzaffar, @jfernan2, @perrotta, @makortel can you please check and sign again.

bsunanda · 2024-05-26T04:13:22Z

Destroyed the PR by attempting squashing. A new PR is made in #45045

Run3-alca247YX Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs (restore the material from #45010)

cmsbuild added this to the CMSSW_14_1_X milestone May 21, 2024

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 21, 2024

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels May 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2024

cmsbuild added tests-started and removed tests-pending labels May 21, 2024

cmsbuild added tests-approved and removed tests-started labels May 21, 2024

perrotta reviewed May 22, 2024

View reviewed changes

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels May 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 22, 2024

VinInn and others added 13 commits May 26, 2024 06:03

make TempTrajectory smaller and faster to move

5e1eb87

reduce size of Traj as well

cd2a12f

remove unused instances of TempTrajectory

d5d9fff

this was a real (old) bug

0c84f0d

simplify logic to limit the number of candidates

f9a0700

remove very old commented code

604e21a

do not sort, limit to maxCand in grouped as well

8385d53

Improvements to python configuration syntax

74a1316

- Can now use tuples to set parameters that take multiple values - Improved validation of values passed to V* parameters

Generated cfi files now may use new module syntax

76277b6

- denote if must use full type info when dumping to cfi - test module now makes explicit named cfi files compatible with default

Fix left over merge conflicts

b9a6167

Add examples for the IsoTrack calibration in Calibration/HcalCalibAlg…

8884866

…os/macros/jobs

Code check

6bc5acf

Take andreas comments

8beaca7

bsunanda force-pushed the Run3-alca247Y branch from c61d014 to 8beaca7 Compare May 26, 2024 04:04

cmsbuild added reconstruction-pending core-pending tests-pending code-checks-pending tracking and removed tests-approved code-checks-approved labels May 26, 2024

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request May 26, 2024

Add examples for the IsoTrack calibration in Calibration/HcalCalibAlg…

5aeffe3

…os/macros/jobs (restore the material from cms-sw#45010)

bsunanda mentioned this pull request May 26, 2024

Run3-alca247YX Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs (restore the material from #45010) #45045

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels May 26, 2024

bsunanda closed this May 26, 2024

cmsbuild added a commit that referenced this pull request May 28, 2024

Merge pull request #45045 from bsunanda/Run3-alca247YX

ab77a26

Run3-alca247YX Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs (restore the material from #45010)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs #45010

Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs #45010

bsunanda commented May 21, 2024

cmsbuild commented May 21, 2024 •

edited

Loading

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

bsunanda commented May 21, 2024

cmsbuild commented May 21, 2024

perrotta left a comment

perrotta May 22, 2024

cmsbuild commented May 22, 2024

cmsbuild commented May 26, 2024

cmsbuild commented May 26, 2024

bsunanda commented May 26, 2024

Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs #45010

Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs #45010

Conversation

bsunanda commented May 21, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented May 21, 2024 • edited Loading

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

bsunanda commented May 21, 2024

cmsbuild commented May 21, 2024

Comparison Summary

perrotta left a comment

Choose a reason for hiding this comment

perrotta May 22, 2024

Choose a reason for hiding this comment

cmsbuild commented May 22, 2024

cmsbuild commented May 26, 2024

cmsbuild commented May 26, 2024

bsunanda commented May 26, 2024

cmsbuild commented May 21, 2024 •

edited

Loading