Use standard edm::exceptionContext() in Worker::prePrefetchSelectionAsync()

[makortel]

PR description:

This PR improves the exception message added in #44767 in response to #44891 (comment) . It turned out the standard edm::exceptionContext() was appropriate here.

An example of the present message

----- Begin Fatal Exception 02-May-2024 21:13:44 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  Event run: 355769 lumi: 35 event: 22311221 stream: 0
   [1] Running path 'ALCARECOStreamTkAlV0sOutPath'
   [2] Calling OutputModule prePrefetchSelection()
Exception Message:
EventSelector::init, An OutputModule is using SelectEvents
to request a trigger name that does not exist
The unknown trigger name is: pathALCARECOTkAlK0s
----- End Fatal Exception -------------------------------------------------

An example of the message with this PR

----- Begin Fatal Exception 03-May-2024 15:57:21 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  Event run: 355769 lumi: 35 event: 22311221 stream: 0
   [1] Running path 'ALCARECOStreamTkAlV0sOutPath'
   [2] Prefetching for module PoolOutputModule/'ALCARECOStreamTkAlV0s'
Exception Message:
EventSelector::init, An OutputModule is using SelectEvents
to request a trigger name that does not exist
The unknown trigger name is: pathALCARECOTkAlK0s
----- End Fatal Exception -------------------------------------------------

Resolves cms-sw/framework-team#920

PR validation:

Tested locally the exception message change

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44944/40215

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/Worker.cc modified in PR(s): Added noexcept to methods called by async functions #44902

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• FWCore/Framework (core)

@Dr15Jones, @makortel, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7980ea/39327/summary.html
COMMIT: 5bc2ea7
CMSSW: CMSSW_14_1_X_2024-05-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44944/39327/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3332476
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3332456
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1