Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filterBit to EGMNano [14_0_X] #44812

Merged

Conversation

RSalvatico
Copy link
Contributor

PR description:

This is a quasi-backport of #44809, in that the filterBit name that was corrected in that PR had already been corrected in 140X, so the current PR is just adding one more filterBit.

PR validation:

No special validation needed besides what was already done in #44496 and #44524.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 23, 2024
@RSalvatico
Copy link
Contributor Author

type egamma

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2024

A new Pull Request was created by @RSalvatico for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2024

cms-bot internal usage

@RSalvatico
Copy link
Contributor Author

enable nano

@RSalvatico
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2efd3e/39027/summary.html
COMMIT: ff19e64
CMSSW: CMSSW_14_0_X_2024-04-22-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44812/39027/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.90 3.92 -0.5% 2.173 2.253
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.51 3.47 +1.1% 2.565 2.672
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.62 3.64 -0.5% 2.551 2.670
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.80 6.92 -1.7% 2.273 2.373
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.67 3.69 -0.6% 2.431 2.562
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.33 5.39 -1.0% 2.364 2.466
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.13 5.08 +1.1% 2.085 2.077
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.93 5.77 +2.8% 1.993 1.995
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.24 4.20 +0.9% 2.292 2.296
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.75 3.71 +1.0% 2.273 2.375
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.77 11.42 +3.0% 1.984 1.979
2500.301 2.833 2.833 0.000 ( +0.0% ) 9.88 9.54 +3.6% 1.962 1.966
2500.31 1.348 1.348 0.000 ( +0.0% ) 19.06 18.59 +2.6% 2.350 2.383
2500.311 1.757 1.757 0.000 ( +0.0% ) 13.61 12.93 +5.3% 2.456 2.455
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.40 1.42 -1.0% 1.697 1.697
2500.313 1.568 1.568 0.000 ( +0.0% ) 7.55 6.70 +12.7% 1.041 1.039
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.16 13.26 -0.8% 2.195 2.292
2500.315 1.874 1.874 0.000 ( +0.0% ) 14.03 12.90 +8.7% 2.344 2.347
2500.316 3.342 3.342 0.000 ( +0.0% ) 2.01 2.01 +0.2% 2.190 2.306
2500.317 1.811 1.811 0.000 ( +0.0% ) 13.52 13.71 -1.4% 2.186 2.365
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.50 5.46 +0.8% 2.165 2.351
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.49 11.28 +1.9% 1.865 1.943
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.72 9.34 +4.1% 1.862 1.865
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.46 9.19 +3.0% 1.739 1.879
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.45 1.41 +2.9% 1.951 1.968
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.68 9.37 +3.3% 1.878 1.901
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.41 3.31 +3.2% 1.726 1.786
2500.5 5.194 5.194 0.000 ( +0.0% ) 16.01 15.79 +1.4% 1.707 1.704
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.76 9.58 +1.9% 1.591 1.649

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

backport of #44809

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9eb3e37 into cms-sw:CMSSW_14_0_X Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants