-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store the hltobjects for Mass50 triggers #44778
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40012
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
type egamma, bug-fix |
@pinchunchou please apply the code formatting as per |
@pinchunchou this branch still fails the code checks. Please apply the code formatting suggested by the bot at #44778 (comment). Also there is a review in the 14.0.X version, can you please address it and port it also here? |
@pinchunchou this PR and its backport to 14_0 seem stuck, please address the comments and update the PRs. |
code-checks |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40147
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Hi @Martin-Grunewald and @mmusich , sorry for the late reply. I have applied the fix on code format in the newest commit. Thanks! |
@pinchunchou, there is a review in the 14.0.X version #44746, can you please address it and port it also here? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40270
|
Thanks for checking. Fixed |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40755
|
Pull request #44778 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bc537/40149/summary.html
Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bc537/40159/summary.html
Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
We've encountered an issue with the Mass50 HLT triggers for double electrons (Ele15Ele10GsfMass50, DoubleEle10GsfMass50, and DoubleEle15GsfMass50) in both ppref and HI HLT menus. These HLT triggers are not storing any information in the hltobject trees, even though the events are being triggered. After investigating, we have identified that the problem lies with HLTEgammaCombMassFilter.
I have made some modifications to HLTEgammaCombMassFilter, and now the information is being stored in hltobject.
See slides: https://twiki.cern.ch/twiki/pub/CMS/HLT_HIon_Run3/pinchun20230928.pdf (P.8)
Backport PR:
#44746 (14_0_X)