High pT Tracks resolved: Fitting each track as a Helix! Dropping the …

[ykumar05]

…Huge radius expression.

PR description:

• High pT muon tracks (>1.2 TeV) were reconstructed with values twice that of their generated counterparts.
• Other high pT tracks in the inner region diverged completely, behaving as they traveled in straight lines.
• The issue was traced to an expression in the Trajectory. cc file located at FastSimulation/SimplifiedGeometryPropagator/src, which imposed a threshold causing tracks beyond a certain value to be assumed straight (with a huge radius).
• By removing this condition, I observed that the reconstructed pT aligned properly with the simulated generated pT.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44748/39961

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FastSimulation/SimplifiedGeometryPropagator/src/Trajectory.cc modified in PR(s): HighPt Track Resolved: Fitting each track as a Helix. Refer FastSimul… #44644

[cmsbuild]

A new Pull Request was created by @ykumar05 for master.

It involves the following packages:

• FastSimulation/SimplifiedGeometryPropagator (fastsim)

@ssekmen, @civanch, @mdhildreth, @sbein, @cmsbuild can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[sbein]

Thanks @ykumar05 for this much needed fix! I have tested this and found it has 0 impact on SUSY physics
https://www.desy.de/~beinsam/FastSim/Nano/T1ttttRun3_Fast_C14X/index.html

This is the case for all produced samples - however, it will affect future Z-prime, W-prime production, or other heavy decay searches.

[sbein]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

Backport plan: At least
Run2UL: 10_6
Run3-2022: 12_4
Run3-2023: 13_0
Run3-2024: 14_0

FYI @sbein @civanch

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98a2b6/38864/summary.html
COMMIT: 11701c2
CMSSW: CMSSW_14_1_X_2024-04-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44748/38864/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially added 82 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319475
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319449
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[sbein]

I'm not sure why this error occurred but I don't think it can be the fault of the PR:

===== Test "test-das-selected-lumis" ====
+ export CMS_BOT_USE_DASGOCLIENT=true
+ CMS_BOT_USE_DASGOCLIENT=true
+ QUERY='lumi,file dataset=/HIHardProbes/HIRun2018A-v1/RAW run=326479'
+ dasgoclient --limit 0 --query 'lumi,file dataset=/HIHardProbes/HIRun2018A-v1/RAW run=326479' --format json
+ das-selected-lumis.py 1,23
+ grep '^/store/'

---> test test-das-selected-lumis had ERRORS
TestTime:1
^^^^ End Test test-das-selected-lumis ^^^^

[sbein]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98a2b6/38933/summary.html
COMMIT: 11701c2
CMSSW: CMSSW_14_1_X_2024-04-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44748/38933/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319599
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319576
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[rappoccio]

+1