Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory use when writing ParameterSets to files [13_3] #44740

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

When forwarding a VPSet from the input file to the output, avoid calling vpset() which triggers creating the entire vector.

PR validation:

Code compiles.

backport of #44727

When forwarding a VPSet from the input file to the output, avoid
calling vpset() which triggers creating the entire vector.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for CMSSW_13_3_X.

It involves the following packages:

  • FWCore/ParameterSet (core)

@cmsbuild, @makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c8e81/38856/summary.html
COMMIT: 025a429
CMSSW: CMSSW_13_3_X_2024-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44740/38856/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 75fc906 into cms-sw:CMSSW_13_3_X Apr 16, 2024
10 checks passed
@Dr15Jones Dr15Jones deleted the fixPSetWriteMemory_13_3 branch April 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants