adding HoE Tower based for photons

[TizianoBevilacqua]

PR description:

With this pull request I added the two versions of Photon HoE calculation to the nAOD variable output. Previously for run 3 the HoE dumped was calo based while for run 2 it was Tower based. Both are needed in both cases for H(gg) analyses.

PR validation:

To test I've created a nAOD starting from Run2 data samples and checked that both version of HoE are dumped correctly

@lfinco @fcouderc

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44728/39939

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Introduce Unified Particle Transformer AK4 jet tagger #44641, Add Unified ParT to tau NanoAOD #44691
  • File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): Explicit lazy parsing in SimpleFlatTableProducer #44575

[cmsbuild]

A new Pull Request was created by @TizianoBevilacqua for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3da185/38825/summary.html
COMMIT: 6185efe
CMSSW: CMSSW_14_1_X_2024-04-12-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44728/38825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 53 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 90 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316240
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.8090000000000006 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 0.247 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): 0.120 KiB Physics/NanoAODDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16484
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16475
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.569 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): 0.247 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.011,... ): 0.120 KiB Physics/NanoAODDQM
• Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.577	2.574	0.003 ( +0.1% )	3.04	4.60	-33.9%	1.884	2.234
2500.001	2.724	2.721	0.003 ( +0.1% )	2.71	4.09	-33.7%	2.166	2.655
2500.002	2.670	2.667	0.003 ( +0.1% )	2.82	4.24	-33.5%	2.147	2.653
2500.01	1.323	1.320	0.003 ( +0.2% )	5.67	8.34	-32.0%	1.957	2.353
2500.011	1.745	1.741	0.004 ( +0.2% )	3.12	4.63	-32.6%	1.997	2.539
2500.012	1.586	1.583	0.004 ( +0.2% )	4.44	6.58	-32.5%	1.854	2.445
2500.1	2.263	2.259	0.004 ( +0.2% )	2.99	4.54	-34.3%	2.061	2.071
2500.2	2.368	2.366	0.002 ( +0.1% )	3.41	5.18	-34.2%	1.948	1.981
2500.21	1.203	1.200	0.002 ( +0.2% )	2.32	3.51	-34.1%	1.970	2.266
2500.211	1.571	1.568	0.003 ( +0.2% )	1.94	3.13	-38.0%	2.064	2.342
2500.3	2.140	2.139	0.001 ( +0.1% )	6.28	9.79	-35.8%	1.958	1.965
2500.301	2.733	2.730	0.003 ( +0.1% )	4.89	7.95	-38.4%	1.966	1.958
2500.31	7.164	7.164	0.000 ( +0.0% )	0.93	1.35	-30.9%	1.713	1.707
2500.311	1.568	1.568	0.000 ( +0.0% )	5.17	6.53	-20.9%	1.057	1.061
2500.312	540.457	540.457	0.000 ( +0.0% )	0.32	0.52	-38.4%	1.594	1.586
2500.313	817.694	817.694	0.000 ( +0.0% )	0.42	0.71	-41.2%	1.581	1.577
2500.32	1.285	1.283	0.002 ( +0.2% )	8.07	13.01	-38.0%	1.955	2.367
2500.321	1.677	1.675	0.002 ( +0.1% )	5.77	9.72	-40.7%	2.059	2.441
2500.322	1.195	1.195	0.000 ( +0.0% )	6.06	10.14	-40.2%	1.889	2.135
2500.323	7.772	7.772	0.000 ( +0.0% )	2.25	3.39	-33.8%	1.954	1.933
2500.324	1.794	1.791	0.002 ( +0.1% )	6.07	9.89	-38.6%	1.967	2.205
2500.325	4.178	4.176	0.002 ( +0.1% )	2.56	4.05	-36.9%	2.003	2.224
2500.326	3.129	3.127	0.002 ( +0.1% )	1.14	1.81	-37.1%	1.978	2.219
2500.327	1.825	1.822	0.002 ( +0.1% )	6.18	9.91	-37.7%	1.969	2.348
2500.4	2.309	2.308	0.002 ( +0.1% )	5.93	9.37	-36.8%	1.688	1.833
2500.401	1.855	1.855	0.000 ( +0.0% )	4.87	7.89	-38.3%	1.838	1.708
2500.402	2.876	2.874	0.003 ( +0.1% )	4.74	8.04	-41.1%	1.916	1.916
2500.403	8.833	8.830	0.003 ( +0.0% )	1.76	2.72	-35.4%	1.910	1.887
2500.404	5.186	5.183	0.003 ( +0.1% )	0.87	1.32	-34.1%	1.901	1.782
2500.405	2.884	2.881	0.003 ( +0.1% )	5.08	8.01	-36.6%	1.663	1.915
2500.5	5.194	5.194	0.000 ( +0.0% )	10.89	15.88	-31.4%	1.086	1.574
2500.51	9.120	9.120	0.000 ( +0.0% )	6.59	9.59	-31.3%	1.046	1.520

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1