Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] backport of 44335 (slimmedMETsNoHF and possible cleanup) #44707

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 11, 2024

PR description:

  • slimmedMETsNoHF collection in MiniAOD is just MET without considering PF candidates in the HF region
  • Its impact on the MiniAOD size is negligible
  • it clusters a new CHS jet collection (ak4PFJetsCHSNoHF) which is used for its Type-1 correction consuming a non-negligible CPU time
  • No use cases at the moment therefore it can be removed from MiniAOD production workflow

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

@hqucms hqucms changed the title [14]slimmedMETsNoHF and possible cleanup [14_0_X] backport of 44335 (slimmedMETsNoHF and possible cleanup) Apr 11, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 11, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

A new Pull Request was created by @hqucms for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Physics (dqm)
  • PhysicsTools/PatAlgos (reconstruction, xpog)

@syuvivida, @antoniovagnerini, @cmsbuild, @nothingface0, @mandrenguyen, @jfernan2, @vlimant, @tjavaid, @rvenditti, @hqucms can you please review it and eventually sign? Thanks.
@mmarionncern, @schoef, @ahinzmann, @mbluj, @rappoccio, @andrzejnovak, @nhanvtran, @gkasieczka, @hatakeyamak, @azotz, @jdolen, @mariadalfonso, @demuller, @jdamgov, @castaned, @gpetruc, @Senphy, @gouskos, @Ming-Yan, @AlexDeMoor, @seemasharmafnal this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented Apr 11, 2024

please test

@jfernan2
Copy link
Contributor

backport of #44335

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8128b/38783/summary.html
COMMIT: ba9712d
CMSSW: CMSSW_14_0_X_2024-04-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44707/38783/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 72 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 807 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308031
  • DQMHistoTests: Total failures: 1382
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3306629
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -95.97000000000003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -2.742 KiB Physics/Top
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@hqucms
Copy link
Contributor Author

hqucms commented Apr 11, 2024

+1

@mandrenguyen
Copy link
Contributor

+reconstruction
This is simply removing part of the slimmedMET collection (miniAOD) that is not used.
This is should therefore be safe for reco for a closed release.

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f3de8c4 into cms-sw:CMSSW_14_0_X Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants