Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tau Filterbits for 2024 Data Taking #44688

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Updated Tau Filterbits for 2024 Data Taking #44688

merged 1 commit into from
Apr 11, 2024

Conversation

brallmond
Copy link
Contributor

@brallmond brallmond commented Apr 10, 2024

This PR is to update filterbits in NanoAOD V14 for 2024 data taking, and for 2022/2023 ReReco campaigns.

The PR adds filter bits for Tau ParticleNet at HLT filters to the electron, muon, tau, and jet collections.
The PR also re-arranges the order of some Tau filter bits, as part of combining/making room for the new bits.

To fit the PNet bits into the Tau collection (since there cannot be more than 30 bits), it was necessary to double-up the DeepTau and Pnet signal and monitoring filter bits. It is possible to do this by requiring an additional bit that is exclusively PNet or DeepTau.
In the process of implementing the PNet bits, several non-functioning DeepTau bits were also updated, enabling more Tau triggers to be matched, specifically VBF SingleTau.

The changes were tested by re-emulating signal files from the HLT decision to NanoAOD, and then observing the filter bits at the NanoAOD level.

This PR does not depend on other PRs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44688/39886

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @brallmond for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c1529/38734/summary.html
COMMIT: 5d91da8
CMSSW: CMSSW_14_1_X_2024-04-10-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44688/38734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 88 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16484
  • DQMHistoTests: Total failures: 176
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16308
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.574 2.574 0.000 ( +0.0% ) 4.58 4.50 +1.7% 2.204 2.209
2500.001 2.722 2.722 0.000 ( +0.0% ) 3.91 4.02 -2.8% 2.596 2.231
2500.002 2.667 2.667 0.000 ( +0.0% ) 4.24 4.16 +1.9% 2.581 2.249
2500.01 1.318 1.318 0.000 ( +0.0% ) 8.38 8.08 +3.8% 2.345 1.986
2500.011 1.739 1.739 0.000 ( +0.0% ) 4.63 4.50 +2.9% 2.537 1.999
2500.012 1.580 1.580 0.000 ( +0.0% ) 6.58 6.36 +3.4% 2.382 2.017
2500.1 2.259 2.218 0.041 ( +1.9% ) 4.57 4.49 +1.8% 2.074 2.052
2500.2 2.366 2.333 0.033 ( +1.4% ) 5.22 5.08 +2.6% 1.981 1.931
2500.21 1.198 1.182 0.015 ( +1.3% ) 3.54 3.46 +2.3% 2.329 1.954
2500.211 1.566 1.546 0.020 ( +1.3% ) 3.17 3.04 +4.2% 2.348 2.052
2500.3 2.139 2.089 0.050 ( +2.4% ) 9.80 9.56 +2.5% 1.981 1.961
2500.301 2.730 2.667 0.064 ( +2.4% ) 8.23 8.10 +1.6% 1.949 1.957
2500.31 7.159 7.159 0.000 ( +0.0% ) 1.39 1.33 +4.1% 1.701 1.702
2500.311 1.564 1.564 0.000 ( +0.0% ) 7.11 6.94 +2.4% 1.049 1.052
2500.312 540.453 540.453 0.000 ( +0.0% ) 0.53 0.49 +6.5% 1.601 1.592
2500.313 817.689 817.689 0.000 ( +0.0% ) 0.73 0.67 +9.2% 1.577 1.604
2500.32 1.280 1.256 0.024 ( +1.9% ) 13.15 12.01 +9.5% 2.363 1.905
2500.321 1.672 1.643 0.029 ( +1.8% ) 9.76 9.19 +6.3% 2.406 2.090
2500.322 1.192 1.163 0.029 ( +2.5% ) 10.18 9.91 +2.7% 2.070 2.125
2500.323 7.768 7.768 0.000 ( +0.0% ) 3.49 3.25 +7.5% 1.926 1.822
2500.324 1.789 1.759 0.030 ( +1.7% ) 10.07 9.62 +4.6% 2.187 2.176
2500.325 4.173 4.144 0.029 ( +0.7% ) 4.21 4.05 +3.8% 2.235 1.793
2500.326 3.124 3.095 0.029 ( +1.0% ) 1.80 1.71 +5.0% 2.078 1.926
2500.327 1.820 1.791 0.029 ( +1.6% ) 10.05 9.74 +3.2% 2.336 2.034
2500.4 2.307 2.245 0.062 ( +2.7% ) 9.39 9.15 +2.6% 1.845 1.826
2500.401 1.855 1.778 0.077 ( +4.4% ) 8.23 8.09 +1.8% 1.720 1.699
2500.402 2.874 2.795 0.078 ( +2.8% ) 7.83 7.93 -1.3% 1.907 1.908
2500.403 8.830 8.752 0.078 ( +0.9% ) 2.81 2.65 +6.2% 1.874 1.821
2500.404 5.183 5.105 0.078 ( +1.5% ) 1.33 1.28 +4.0% 1.769 1.782
2500.405 2.881 2.803 0.078 ( +2.8% ) 8.15 7.71 +5.7% 1.907 1.901
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.89 15.28 +4.0% 1.567 1.562
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.61 9.42 +2.0% 1.513 1.512

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

type tau

@cmsbuild cmsbuild added the tau label Apr 10, 2024
@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants