Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for low-level alpaka based utilities #44640

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 5, 2024

PR description:

Fix various low-level alpaka based utilities that were inadvertently mixing host and device code.

Required to build with alpaka in GPU-only mode.

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

These changes should improve the correctness of the alpaka-based algorithms, and it would be a good idea to backport them to CMSSW 14.0.x for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44640/39835

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@fwyzard fwyzard force-pushed the alpaka_code_fixes_141x branch from 51a4dd3 to c146ea1 Compare April 5, 2024 23:50
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44640/39836

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@rovere, @missirol, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74db24/38646/summary.html
COMMIT: c146ea1
CMSSW: CMSSW_14_1_X_2024-04-05-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44640/38646/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 34 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1683
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38057
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 6, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e512c9 into cms-sw:master Apr 8, 2024
14 checks passed
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

@jsamudio FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants