-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for low-level alpaka based utilities #44640
Conversation
type bugfix |
enable gpu |
please test |
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44640/39835
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
51a4dd3
to
c146ea1
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44640/39836
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74db24/38646/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@jsamudio FYI |
PR description:
Fix various low-level alpaka based utilities that were inadvertently mixing host and device code.
Required to build with alpaka in GPU-only mode.
PR validation:
Unit tests pass.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
These changes should improve the correctness of the alpaka-based algorithms, and it would be a good idea to backport them to CMSSW 14.0.x for data taking.