Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X SIM] Clean-up MC truth infrastructure #44593

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Apr 2, 2024

PR description:

Updated SIM classes responsible for MC truth. No change of results are expected.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44593/39767

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @civanch for master.

It involves the following packages:

  • SimG4CMS/Calo (simulation)
  • SimG4Core/Application (simulation)
  • SimG4Core/GeometryProducer (simulation)
  • SimG4Core/Notification (simulation)

@mdhildreth, @civanch, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @bsunanda, @ReyerBand, @rovere, @wang0jin, @thomreis, @felicepantaleo, @slomeo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Apr 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c332c/38554/summary.html
COMMIT: a198bdb
CMSSW: CMSSW_14_1_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44593/38554/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor Author

civanch commented Apr 3, 2024

+1

pure technical

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 597b257 into cms-sw:master Apr 3, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants