Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TensorFlowAOT unit tests, remove dev workflow. #44519

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

riga
Copy link
Contributor

@riga riga commented Mar 22, 2024

PR description

This PR is a continuation of #43941 and should be tested with cms-sw/cmsdist#9093.

The development workflow for AOT compiling TensorFlow models was added to the PhysicsTools/TensorFlowAOT package in the above mentioned PR. However, with the new changes to the build process and deployment via cmsdist, these files can be removed again (as done in this PR). Instructions on how to locally AOT compile and use models for development purposes will be published on pages of the ML group soon.

PR validation

Since the pre-compiled test models are now provided as external tools, this PR enables the unit tests of the AOT interface that were already reviewed. They perform tests of a simple f32 -> f32 model, as well as a multi-input/output model with a f32,f64 -> f32,bool signature.

@Bogdan-Wiederspan @valsdav

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44519/39645

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44519/39646

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @riga for master.

It involves the following packages:

  • PhysicsTools/TensorFlowAOT (ml)

@wpmccormack, @cmsbuild, @valsdav can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44519/39693

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44519 was updated. @wpmccormack, @valsdav, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @rappoccio: This PR was tested with cms-sw/cmsdist#9093, please check if they should be merged together

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#9093

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94885c/38486/summary.html
COMMIT: 7c477f1
CMSSW: CMSSW_14_1_X_2024-03-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44519/38486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 124 lines to the logs
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297437
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297408
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@cms-sw/ml-l2 , can you please review this? This needs to go in along with cms-sw/cmsdist#9093

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @antoniovilela, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9093, please check if they should be merged together

@valsdav
Copy link
Contributor

valsdav commented Mar 28, 2024

+ml

Thanks a lot @riga @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9093

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f57259e into cms-sw:master Mar 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants