Apply rule-of-5 to ESPreFunctorDecorator

[Dr15Jones]

PR description:

This avoids a compiler warning under clang.

PR validation:

Compiling code under CMSSW_14_1_CLANG_X_2024-03-19-2300 no longer issues a warning.

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44483/39572

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/Framework (core)

@smuzaffar, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @missirol, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

Just to double check, this class is copyable and movable via constructor, but not via assignment? I.e. assigning to a caller_ (when not initializing it) is what we want to avoid? But copying caller_ as such is fine?

[Dr15Jones]

The original code stopped the regular op= but the compiler warning complained about the default copy constructor. To make the code work, I had to require the copy constructor (and figured move constructor would be fine). Then I just picked the move op= to be treated like the regular op=.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32a07f/38283/summary.html
COMMIT: 4d857dc
CMSSW: CMSSW_14_1_X_2024-03-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44483/38283/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 67 lines to the logs
• Reco comparison results: 71 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 1364
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3295985
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Comparisons show the usual

• spurious differences in outputs of Run-3 wfs *.7 #39803
• Non reproducibility in wf 136.793 #43293
• Non-reproducibility in TriggerResults in 24834.0, 24834.911, and 25034.999 #43790

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1