Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Add use of unsubtracted jets in RecoBTag info producers #44475

Merged

Conversation

stahlleiton
Copy link
Contributor

PR description:

backport of #44422

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

A new Pull Request was created by @stahlleiton for CMSSW_13_2_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)
  • RecoJets/JetProducers (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@gkasieczka, @jdolen, @emilbols, @rappoccio, @Ming-Yan, @seemasharmafnal, @Senphy, @AnnikaStein, @mariadalfonso, @jdamgov, @clelange, @missirol, @AlexDeMoor, @demuller, @JyothsnaKomaragiri, @yslai, @andrzejnovak, @nhanvtran, @schoef, @ahinzmann, @hqucms this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #44475 was updated. @cmsbuild, @mandrenguyen, @jfernan2 can you please check and sign again.

@mandrenguyen
Copy link
Contributor

@stahlleiton Was there a 13_3_X PR too?

@stahlleiton
Copy link
Contributor Author

@stahlleiton Was there a 13_3_X PR too?

#44579

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

type btv

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-629736/38542/summary.html
COMMIT: 21c9119
CMSSW: CMSSW_13_2_X_2024-03-31-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44475/38542/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

Need to apply fix from #44591.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

Pull request #44475 was updated. @jfernan2, @mmusich, @mandrenguyen, @Martin-Grunewald, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

@stahlleiton it is possible to avoid the "merge" in the commit history of this PR?

@mandrenguyen
Copy link
Contributor

backport of #44422

@stahlleiton
Copy link
Contributor Author

@stahlleiton it is possible to avoid the "merge" in the commit history of this PR?

The release I was working on was deleted. So I had to start with a new IB release. I can try to squash the commits if you prefer.

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

I can try to squash the commits if you prefer.

yes, rebasing against the latest 13.2.X IB (thus removing the merge) is the preferred option.

@stahlleiton stahlleiton force-pushed the UnsubJetsForBTag_CMSSW_13_2_X branch from fd81f00 to 96402f8 Compare April 3, 2024 07:58
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

Pull request #44475 was updated. @Martin-Grunewald, @mandrenguyen, @cmsbuild, @mmusich, @jfernan2 can you please check and sign again.

@stahlleiton
Copy link
Contributor Author

I can try to squash the commits if you prefer.

yes, rebasing against the latest 13.2.X IB (thus removing the merge) is the preferred option.

done, I rebased against latest IB

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

done, I rebased against latest IB

thank you @stahlleiton

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-629736/38564/summary.html
COMMIT: 96402f8
CMSSW: CMSSW_13_2_X_2024-03-31-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44475/38564/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

+hlt

  • in this cycle the new parameter unsubjet_map of DeepBoostedJetTagInfoProducer has never been defined as untracked.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3864710 into cms-sw:CMSSW_13_2_X Apr 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants