-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added python type annotation to some configuration classes #44453
Conversation
- Added for the cases where it was easy to determine the type
please test |
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44453/39529
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@smuzaffar, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-332034/38235/summary.html Comparison SummarySummary:
|
@cmsbuild, please test Let's refresh just to make sure |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-332034/38500/summary.html Comparison SummarySummary:
|
+1 |
PR description:
PR validation:
Framework tests pass.
NOTE: python does not enforce the type, it is only useful for other tools.