Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track sort order in PixelTrackProducerFromSoAAlpaka [14.0.x] #44442

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 17, 2024

PR description:

Port the fix to PixelTrackProducerFromSoA from #42428 by @silviodonato to PixelTrackProducerFromSoAAlpaka.

Clean up PixelTrackProducerFromSoA and PixelTrackProducerFromSoAAlpaka.

PR validation:

The online HLT menu v1 was run with these changes.

Backport status

Backported of #44441 for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • RecoTracker/PixelTrackFitting (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@mmusich, @JanFSchulte, @GiacomoSguazzoni, @missirol, @dgulhan, @mtosi, @gpetruc, @VinInn, @felicepantaleo, @rovere, @VourMa this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

backport #44441

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-528385/38199/summary.html
COMMIT: 1170ffc
CMSSW: CMSSW_14_0_X_2024-03-17-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44442/38199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 585
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39155
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a871ae0 into cms-sw:CMSSW_14_0_X Mar 19, 2024
13 checks passed
@fwyzard fwyzard deleted the fix_PixelTrackProducerFromSoAAlpaka_along_42428_140x branch April 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants