Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the HLT alpaka customisation [14.0.x] #44440

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Update the HLT alpaka customisation [14.0.x] #44440

merged 2 commits into from
Mar 20, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 17, 2024 •
edited
Loading

PR description:

Customise the GPU checks to use the AlpakaBackendFilter:

  • customise the Status_On{CPU|GPU} HLT paths and the DQM_{Ecal|Hcal|Pixel}Reconstruction_v* HLT paths to use the AlpakaBackendProducer and AlpakaBackendFilter modules.

Delete legacy modules and tasks after defining the alpaka ones.
Clean up white space and indentation.

PR validation:

The online HLT menu 2024 v1 was run with and without these changes.

Backport status

Backport of #44439 for data taking.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Mar 17, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2024 •
edited
Loading

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2024 •
edited
Loading

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024 •
edited
Loading

Note: this PR includes some of the changes from #44416, and may need to be rebased once that one is merged.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

backport #44439

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

please test

@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2024

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 17, 2024
@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2024

unhold

  • this needs to be rebased now

@cmsbuild cmsbuild removed the hold label Mar 17, 2024
@fwyzard
Update the HLT alpaka customisation
9397049 
Delete legacy modules and tasks after defining the alpaka ones.
Clean up white space and indentation.
@fwyzard fwyzard force-pushed the update_customizeHLTforAlpaka_140x branch from e65deef to 9397049 Compare March 17, 2024 15:11
@cmsbuild
Copy link
Contributor

Pull request #44440 was updated. @Martin-Grunewald, @mmusich, @cmsbuild can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

Rebased on top of the current HEAD of CMSSW_14_0_X.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

please test

@fwyzard
Customise the GPU checks to use the AlpakaBackendFilter
8bae51b 
Customise the Status_On{CPU|GPU} HLT paths and the
DQM_{Ecal|Hcal|Pixel}Reconstruction HLT paths to use the AlpakaBackendProducer
and AlpakaBackendFilter modules.
@cmsbuild
Copy link
Contributor

Pull request #44440 was updated. @cmsbuild, @Martin-Grunewald, @mmusich can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 17, 2024

please test with #44388

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a5537/38201/summary.html
COMMIT: 8bae51b
CMSSW: CMSSW_14_0_X_2024-03-17-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44440/38201/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a5537/38201/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a5537/38201/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 19 lines from the logs
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3336983
  • DQMHistoTests: Total failures: 3344
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3333617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.092 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.156 KiB HLT/Filters
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 7 / 47 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1334
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38406
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44388

@cmsbuild cmsbuild mentioned this pull request Mar 19, 2024
Merged
@antoniovilela
Copy link
Contributor

type hlt-int

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 485719d into cms-sw:CMSSW_14_0_X Mar 20, 2024
13 checks passed
@fwyzard fwyzard deleted the update_customizeHLTforAlpaka_140x branch April 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved hlt-integration orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@fwyzard @cmsbuild @mmusich @Martin-Grunewald @antoniovilela