Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hanging references to ReconstructionHeavyIons #44329

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

mandrenguyen
Copy link
Contributor

PR description:

Remove traces of old heavy-ion reco that were being used in various unit tests.
Address #44326

PR validation:

compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44329/39357

  • This PR adds an extra 56KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • DQM/BeamMonitor (db, dqm)
  • HeavyIonsAnalysis/Configuration (analysis)
  • RecoHI/HiEgammaAlgos (reconstruction)
  • RecoHI/HiJetAlgos (reconstruction)
  • RecoHI/HiTracking (reconstruction)
  • RecoLocalTracker/SiStripZeroSuppression (reconstruction)
  • Validation/RecoHI (dqm)

@consuegs, @tjavaid, @perrotta, @mandrenguyen, @rappoccio, @saumyaphor4252, @davidlange6, @nothingface0, @antoniovilela, @cmsbuild, @rvenditti, @fabiocos, @syuvivida, @jfernan2, @antoniovagnerini, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@dgulhan, @PonIlya, @gbenelli, @francescobrivio, @jlidrych, @rsreds, @mmusich, @missirol, @threus, @alesaggio, @mtosi, @jazzitup, @fabiocos, @VinInn, @kurtejung, @gpetruc, @JanFSchulte, @yuanchao, @GiacomoSguazzoni, @Martin-Grunewald, @makortel, @yenjie, @yduhm, @rovere, @yetkinyilmaz, @yslai, @echabert, @robervalwalsh, @felicepantaleo, @VourMa, @RylanC24, @kkrajczar this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44329/39358

  • This PR adds an extra 52KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-415505/37931/summary.html
COMMIT: fb77715
CMSSW: CMSSW_14_1_X_2024-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44329/37931/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 100 lines to the logs
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3293492
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3293472
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

+reconstruction
Hopefully this is sufficient to stop the issues in the IBs

@perrotta
Copy link
Contributor

perrotta commented Mar 6, 2024

+db

@tvami
Copy link
Contributor

tvami commented Mar 6, 2024

+analysis

@antoniovilela
Copy link
Contributor

@cms-sw/dqm-l2
Please review & sign.
Thanks.

@tjavaid
Copy link

tjavaid commented Mar 7, 2024

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants