add non-empty checks in DAClusterizer to avoid reading null refs

[slava77]

to address #44277

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44281/39302

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 for master.

It involves the following packages:

• RecoVertex/PrimaryVertexProducer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@VinInn, @mtosi, @missirol, @GiacomoSguazzoni, @mmusich, @rovere, @JanFSchulte, @VourMa, @dgulhan this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ad74e/37881/summary.html
COMMIT: cb42603
CMSSW: CMSSW_14_1_X_2024-03-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44281/37881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 28 lines to the logs
• Reco comparison results: 55 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3339090
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3339062
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

@slava77 @cms-sw/reconstruction-l2
Should this be tested for UBSAN (as it relates to #44277)?

[slava77]

@cmsbuild please test workflow 11602.0 for CMSSW_14_1_UBSAN_X

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ad74e/37912/summary.html
COMMIT: cb42603
CMSSW: CMSSW_14_1_UBSAN_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44281/37912/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[slava77]

step3 log of wf 11602.0 is now clean of the DAClusterizerInZ-related issues

[slava77]

@cmsbuild please test

[slava77]

@cmsbuild please abort

[slava77]

@cmsbuild please test workflow 11602.0

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ad74e/37935/summary.html
COMMIT: f2c0197
CMSSW: CMSSW_14_1_X_2024-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44281/37935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3399048
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3399022
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 207 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[slava77]

• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total failures: 6

these are apparently unrelated.

IIUC, the UBSAN issue in this case is mostly false-positive: while the null reference is technically used for a transient value ptr assignment, the values are never used.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1