[14_0_X] Erase from correct vector in PATTauHybridProducer

[makortel]

PR description:

Backport of #44067. From the original PR description

Erasing an element from pfChs using an iterator from pfGammas is undefined behavior. Based on the surrounding code, I guess the intention was to erase the element from pfGammas.

PR validation:

None beyond #44067

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44067

[cmsbuild]

A new Pull Request was created by @makortel for CMSSW_14_0_X.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction, xpog)

@jfernan2, @mandrenguyen, @hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @azotz, @andrzejnovak, @demuller, @mbluj, @rappoccio, @gkasieczka, @AlexDeMoor, @schoef, @jdamgov, @mariadalfonso, @jdolen, @ahinzmann, @AnnikaStein, @mmarionncern, @gouskos, @nhanvtran, @JyothsnaKomaragiri, @Ming-Yan, @emilbols, @Senphy, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Erase from correct vector in PATTauHybridProducer #44067

[cmsbuild]

cms-bot internal usage

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-831a1f/37826/summary.html
COMMIT: 5584911
CMSSW: CMSSW_14_0_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44272/37826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 78 lines from the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3241450
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3241419
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

backport of #44067

[mandrenguyen]

type bug-fix

[mandrenguyen]

+1

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1