Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing newlines in DQM modules #44229

Merged
merged 17 commits into from
Feb 29, 2024
Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 27, 2024

PR description:

Add missing newlines at the end of the files under

DQM/DataScouting
DQM/HcalTasks
DQM/Integration
DQM/L1TMonitorClient
DQM/Physics
DQM/SiPixelMonitorClient
DQM/SiStripMonitorClient
DQM/SiStripMonitorSummary
DQM/TrackerCommon
DQM/TrackerRemapper
DQM/TrackingMonitorSource
DQMOffline/Configuration
DQMOffline/EGamma
DQMOffline/L1Trigger
DQMOffline/Lumi
DQMOffline/MuonDPG
DQMServices/FileIO

.

PR validation:

None.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 27, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44229/39235

  • This PR adds an extra 196KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • DQM/DataScouting (dqm)
  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)
  • DQM/L1TMonitorClient (dqm)
  • DQM/Physics (dqm)
  • DQM/SiPixelMonitorClient (dqm)
  • DQM/SiStripMonitorClient (dqm)
  • DQM/SiStripMonitorSummary (dqm)
  • DQM/TrackerCommon (dqm)
  • DQM/TrackerRemapper (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Configuration (dqm)
  • DQMOffline/EGamma (dqm)
  • DQMOffline/L1Trigger (dqm, l1)
  • DQMOffline/Lumi (dqm)
  • DQMOffline/MuonDPG (dqm)
  • DQMServices/FileIO (dqm)

@syuvivida, @epalencia, @nothingface0, @aloeliger, @antoniovagnerini, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@trocino, @Fedespring, @idebruyn, @fioriNTU, @francescobrivio, @rovere, @JanFSchulte, @mtosi, @calderona, @rociovilar, @cericeci, @DryRun, @venturia, @barvic, @jandrea, @VinInn, @mmusich, @bsunanda, @bellan, @VourMa, @ptcox, @threus, @abbiendi, @HuguesBrun, @missirol, @batinkov, @abdoulline, @sroychow, @arossi83, @rappoccio, @jhgoh this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-062dee/37748/summary.html
COMMIT: e115c69
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44229/37748/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 140.025DAS Error

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3011576
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3011542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-062dee/37769/summary.html
COMMIT: e115c69
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44229/37769/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

  • Technical PR

@tjavaid
Copy link

tjavaid commented Feb 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a37c82c into cms-sw:master Feb 29, 2024
11 checks passed
@fwyzard fwyzard deleted the add_final_newline_DQM branch March 2, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants