-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to restrict single-Path jobs of hltIntegrationTests
to a subset of triggers
#44005
Conversation
…ubset of triggers
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44005/38932
|
A new Pull Request was created by @missirol for master. It involves the following packages:
@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Ah that's useful - can you please make a backport to 14_0? |
Sure, it's in #44007 (same branch). |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bce158/37548/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PRs adds a functionality to the utility
hltIntegrationTests
.Currently, given a HLT menu with N Paths (excluding
HLTriggerFinalPath
),hltIntegrationTests
runs N+1 jobs: one job running the full HLT menu in question, and N jobs each running only one of the N Paths of the menu standalone. This PR adds the option to run the 1-Path-standalone jobs for only a subset M of the Paths in the menu (M < N). This can be useful when testing an update which is known to modify only M Paths, where one normally wants to run (a) the full HLT menu, and (b) standalone jobs only for the M Paths in question, given that the other N-M Paths are unchanged.This is implemented by adding the command-line argument
--paths
tohltIntegrationTests
. In analogy to the--paths
argument ofhltGetConfiguration
, one can specify patterns to select certain Paths using a comma-separated list. One can also specify Paths to be ignored/dropped by prepending the character-
to a given pattern (e.g.--paths "*HLT*,-HLTriggerFinalPath"
to ignore the PathHLTriggerFinalPath
). The scripthltListPaths
is updated accordingly (technically, changing its CLI in a non-backward-compatible way). More details are provided in the help messages of the scripts updated in this PR.Note.
hltIntegrationTests [MENU] -x "--paths A,B,C"
(before and after this PR) corresponds to running 4 jobs: one with a menu containing only 3 Paths (A, B, C), plus 1-Path jobs for each of those 3 Paths (A, B, C).hltIntegrationTests [MENU] --paths A,B,C
(possible only with this PR) also corresponds to running 4 jobs: one with a 'full' menu containing all its Paths (possibly many more than A, B and C), plus 1-Path jobs only for the 3 Paths specified via--paths
(i.e. A, B and C).Minor code improvements are included as well.
Merely technical. No changes expected.
PR validation:
Manual tests, e.g.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
To be backported to
14_0_X
for HLT-menu development in 2024.