-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_0_X] Update LHCInfoProducer to use LHCInfoCombined #43993
[14_0_X] Update LHCInfoProducer to use LHCInfoCombined #43993
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_14_0_X. It involves the following packages:
@tjavaid, @saumyaphor4252, @cmsbuild, @nothingface0, @antoniovagnerini, @syuvivida, @rvenditti, @hqucms, @perrotta, @vlimant, @consuegs can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport of #43956 |
cms-bot internal usage |
enable nano |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e215e0/37520/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
+1
|
Thanks @tjavaid ! Could you also sign the master PR? @cms-sw/alca-l2 A kind ping to sign this backport (you already signed the master one). |
Well, we normally wait for the master PR being merged and passing at least one IB before signing the backports. OTH the AlCa related part is quite trivial here, and I don't see why I should delay our signature also for the backport. Ok, let sign it since now. |
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Verbatim backport of #43956.
This PR updates the NanoAOD
LHCInfoProducer
module to be able to use both oldLHCInfo
(for Run 2) and newLHCInfoPer*
records (for Run 3).PR validation:
See master PR.
Backport:
Backport of #43956.