Phase 2 Integration GTTFileReader expansion and refactor #43968
Conversation
…urated z0 values.
…leReaders to be more descriptive.
…hod in codecs and L1TrackVertexAssociationProducer, minus conflicts from rebase
…set to False for tracks from l1tGTTFileReader
…ional input capability and new parameters to support it.
…options to createFirmwareInputFiles_cfg.py
…d ChannelMap to ChannelIds and Specs maps
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aac48a/37468/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
@NJManganelli Is this ready from your side? You mentioned an issue in your last message in cms-l1t-offline#1188. I think our review was done. |
All good on my side. The issue mentioned prevents switching to the alternative BoardDataReader constructor as Tom suggested, but I don't have time to try debugging that issue for this PR. I will try to reproduce and submit an issue later on. |
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aac48a/37562/summary.html Comparison SummarySummary:
|
|
+l1
|
|
+Upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
We are currently requiring squashing in the more obvious cases. In general however, grouping commits is encouraged in order to simplify the history in cmssw. |
|
+1 |
PR description:
The aim of this PR is to extend the capability of GTT workflows by validating and fixing a minor discrepancy in the loading of vertices from APx/EMPv2 formatted buffer files (APx/Serenity GTT boards), and add a partial implementation for doing the same for tracks written to buffer files (at the stage of "GTT Input"). Along the way, the code is refactored to move common elements from GTTFile{Reader,Writer}.cc plugins to a GTTInterface.h header, as a code/maintainability improvement. Some compile-time constants are made python-configurable (as advised by Tom Williams).
The changes and capabilities added here are not invoked in a typical Phase 2 L1T workflow, and are currently only called for the L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py tool (which is used for creating - and now consuming - buffer files in APx/EMPv2 format for integration tests, and as stepping stones towards eventual Phase 2 GTT packer/unpacker)
Presented in https://indico.cern.ch/event/1352629/contributions/5695626/attachments/2763970/4814068/NickManganelli_GTT_01_12_2023.pdf
PR validation:
This PR passes
scram b code-format
scram b code-checks
scram b
runTheMatrix.py -l limited -i all --ibeos
GTT Firmware workflows: cmsRun createFirmwareInputFiles_cfg.py maxEvents=1008 format=W inputFiles=L1Trigger/DemonstratorTools/python/TT_TuneCP5_14TeV-powheg-pythia8_Phase2Spring23DIGIRECOMiniAOD-PU200_131X_mcRun4_realistic_v5-v1_GEN-SIM-DIGI-RAW-MINIAOD_APxBuffers_cff.py tracks=X vertices=Y readerformat=Z (X and Y in 'donotload' , 'load' , 'overwrite' ; W and Z in 'APx' or 'EMPv2'
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is the port from the cms-l1t-offline integration branch to the master branch
cms-l1t-offline#1188