Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0.X] Introduce HCAL only workflows using Alpaka-based PF clustering #43958

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[14.0.X] Introduce HCAL only workflows using Alpaka-based PF clustering #43958

merged 1 commit into from
Feb 15, 2024

Conversation

jsamudio
Copy link
Contributor

PR description:

This PR adds new workflows to test Alpaka-based PF modules in CMSSW. Introduced are:

  • 0.422: Alpaka, HCAL only, portable
  • 0.423: Alpaka, HCAL only, portable vs CPU validation
  • 0.424: Alpaka, HCAL only, portable profiling
  • 0.492: Alpaka, Pixel quadruplets, Full-Reco

PR validation:

All new workflows tested and passing on 12434.

PF cluster Alpaka vs Legacy validation plots from 12434.423 are available at https://hep.baylor.edu/jsamudio/workflowValidation/

Usual runTheMatrix.py -l limited -i all --ibeos check is done and passes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43701

@hatakeyamak @fwyzard

@jsamudio
Introduce HCAL only workflows using Alpaka-based PF clustering
59d98c4 
First attempt to add full reco workflow

Fix to new workflows

Update readme with new Alpaka-based PF workflows

Remove extraneous process modifier and add new sequences for Legacy comparisons

Fix to Alpaka Full Reco Workflow

Removes gpu modifier in reco step, and note that once PF is included in HLT we can move the digi step from gpu to alpaka modifier

Adjust HCAL-only alpaka workflow numbers

Adjust full-reco Alpaka workflow

Adjust full reco workflow number

Remove harvesting in .424

Fix harvesting to none
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Feb 13, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2024 •
edited
Loading

A new Pull Request was created by @jsamudio for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • Configuration/StandardSequences (operations)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • Validation/RecoParticleFlow (dqm)

@AdrianoDee, @rappoccio, @jfernan2, @mandrenguyen, @antoniovilela, @syuvivida, @antoniovagnerini, @subirsarkar, @sunilUIET, @tjavaid, @fabiocos, @cmsbuild, @nothingface0, @srimanob, @davidlange6, @miquork, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @mmarionncern, @thomreis, @wang0jin, @rovere, @ReyerBand, @felicepantaleo, @lgray, @Martin-Grunewald, @GiacomoSguazzoni, @JanFSchulte, @apsallid, @dgulhan, @mmusich, @hatakeyamak, @youyingli, @VourMa, @slomeo, @seemasharmafnal, @fabiocos, @VinInn, @makortel, @sameasy, @mtosi this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2024 •
edited
Loading

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Feb 13, 2024 •
edited
Loading

test parameters:

  • enable = gpu
  • workflows = 12434.422,12434.423,12434.424,12434.492
  • workflows_gpu = 12434.422,12434.423,12434.424,12434.492
  • workflow_opts = -w upgrade
  • workflow_opts_gpu = -w upgrade

@fwyzard
Copy link
Contributor

fwyzard commented Feb 13, 2024

please test

@mandrenguyen
Copy link
Contributor

backport of #43701

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5deacb/37442/summary.html
COMMIT: 59d98c4
CMSSW: CMSSW_14_0_X_2024-02-13-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43958/37442/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 33 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248601
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 2153
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 37587
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor

fwyzard commented Feb 14, 2024

I assume this

RelVals-INPUT

The relvals timed out after 4 hours.

can be ignored ?

@srimanob
Copy link
Contributor

+Upgrade

Note to @cms-sw/core-l2 if we should review warning on https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5deacb/37442/codeRules/cmsCodeRule1.txt

@smuzaffar
Copy link
Contributor

ignore tests-rejected with external-failure

yes input failure can be ignored. Due to heavy load on jenkins, these tests are running on lxplus nodes and take more than 4 hours. I have updated the job configuration to increase the timeout if test is running on lxplus

@AdrianoDee
Copy link
Contributor

+pdmv

@fwyzard fwyzard mentioned this pull request Feb 14, 2024
Merged
@jfernan2
Copy link
Contributor

+1

@tjavaid
Copy link

tjavaid commented Feb 14, 2024

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (test failures were overridden) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1bdb516 into cms-sw:CMSSW_14_0_X Feb 15, 2024
28 of 29 checks passed
@waredjeb waredjeb mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed operations-approved orp-approved pdmv-approved reconstruction-approved tests-approved tests-external-failure upgrade-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
10 participants
@jsamudio @cmsbuild @fwyzard @mandrenguyen @srimanob @smuzaffar @AdrianoDee @jfernan2 @tjavaid @antoniovilela