Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for PSet description wildcard with plugin #43944

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Changed the ParameterSetDescription unit test to use catch2.
  • Added test for the combination of a wildcard node using a plugin node.

PR validation:

New tests passes.

Also changed the unit test to use catch2.
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43944/38814

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • FWCore/ParameterSet (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @makortel, @wddgit this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bc3f/37396/summary.html
COMMIT: e4a018e
CMSSW: CMSSW_14_1_X_2024-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43944/37396/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bc3f/37396/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35bc3f/37396/git-merge-result

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247438
  • DQMHistoTests: Total failures: 1186
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246230
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19061.808 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 14102.535 KiB TrackerPhase2OTStub/Stubs
  • DQMHistoSizes: changed ( 23234.0,... ): -14102.286 KiB SiOuterTracker/Stubs
  • DQMHistoSizes: changed ( 23234.0,... ): 14027.626 KiB TrackerPhase2TTCluster/Clusters
  • DQMHistoSizes: changed ( 23234.0,... ): -14027.360 KiB SiOuterTracker/Clusters
  • DQMHistoSizes: changed ( 23234.0,... ): 3178.168 KiB TrackerPhase2OTStubV/Stub_RZ
  • DQMHistoSizes: changed ( 23234.0,... ): -25.679 KiB SiOuterTrackerV/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): 20.667 KiB TrackerPhase2OTL1TrackV/Resolution
  • DQMHistoSizes: changed ( 23234.0,... ): 16.476 KiB TrackerPhase2OTL1Track/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): -16.163 KiB SiOuterTracker/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): 2.961 KiB TrackerPhase2OTL1TrackV/Efficiency
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@makortel
Copy link
Contributor

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 could we have this one merged as I have another PR to make which builds on this change.

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 Please merge as this is holding up other development.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b189b9e into cms-sw:master Feb 18, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the newParameterSetDescTest branch February 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants