Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue exception for ROOT file forward incompatiblity problem #43894

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Feb 7, 2024

PR description:

Throw an exception if the ParameterSet parsing finds an unknown entry type. This problem is occurring presently in older releases if they try to read files which contain the new string encoding for ParameterSets.

PR validation:

This same code was tested in CMSSW_12_6 and properly throws the proper exception type containing the proper information when reading a file generated in CMSSW_13_3.

Backporting

This is meant to be back ported to all active releases before CMSSW_13_3: 13_2, 13_1, 13_0, 12_6, 12_4 and 10_6.

part of cms-sw/framework-team#804

This assert was happening when an old release tried to read a file
written by a newer release.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43894/38749

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • FWCore/ParameterSet (core)
  • IOPool/Input (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1536c1/37278/summary.html
COMMIT: a614599
CMSSW: CMSSW_14_1_X_2024-02-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43894/37278/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

makortel commented Feb 7, 2024

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b84eeb into cms-sw:master Feb 9, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the forwardCompat branch February 9, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants